Skip to content

TICLGeom: do not schedule the @alpaka geometry ES producers in FastSim - #51657

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
felicepantaleo:TICLGeom_fastSim_fix
Aug 9, 2026
Merged

TICLGeom: do not schedule the @alpaka geometry ES producers in FastSim#51657
cmsbuild merged 1 commit into
cms-sw:masterfrom
felicepantaleo:TICLGeom_fastSim_fix

Conversation

@felicepantaleo

Copy link
Copy Markdown
Contributor

Phase2 FastSim is a phase2_hgcal process that loads no Alpaka backend and runs no HGCal reco, so scheduling the @alpaka TICLGeom EventSetup producers made the EventProcessor fail to find the plugin at construction.

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51657/50521

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @felicepantaleo for master.

It involves the following packages:

  • RecoHGCal/TICL (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@apsallid, @denizsun, @hatakeyamak, @lecriste, @rovere, @salimcerci, @sameasy, @sobhatta this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

test parameters:

  • workflows = 36434.0,36634.0
  • relval_opts = -w upgrade

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

type bugfix

@mandrenguyen

Copy link
Copy Markdown
Contributor

urgent

@cmsbuild cmsbuild added the urgent label Aug 9, 2026
@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24a1de/55201/summary.html
COMMIT: 32848ea
CMSSW: CMSSW_20_1_X_2026-08-09-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51657/55201/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

----- Begin Fatal Exception 09-Aug-2026 13:07:36 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

the fastsim wf without pileup is fixed. The error in the pileup wf is not connected to the PR

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

test parameters:

  • workflows = 36434.0
  • relval_opts = -w upgrade

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24a1de/55203/summary.html
COMMIT: 32848ea
CMSSW: CMSSW_20_1_X_2026-08-09-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51657/55203/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
36434.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 44 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3589140
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589110
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 197 log files, 164 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

Add the @alpaka TICLGeom EventSetup producers to hgcalLocalRecoTask instead
of attaching them to every phase2_hgcal process. Their EventSetup modules are
then instantiated only when the reco task is scheduled, which is where the
Alpaka accelerator is present, so a process that only loads the reconstruction
sequence without scheduling it (FastSim, the tracker geometry dump tests) no
longer fails to find TICLGeomESProducer@alpaka at EventProcessor construction.
@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51657/50522

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Pull request #51657 was updated. @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please check and sign again.

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

@cmsbuild please test

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24a1de/55209/summary.html
COMMIT: bf7020b
CMSSW: CMSSW_20_1_X_2026-08-09-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51657/55209/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3589140
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589106
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild

cmsbuild commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild
cmsbuild merged commit 5d8b39b into cms-sw:master Aug 9, 2026
11 checks passed
@felicepantaleo
felicepantaleo deleted the TICLGeom_fastSim_fix branch August 9, 2026 20:43
@mandrenguyen

Copy link
Copy Markdown
Contributor

@felicepantaleo

Copy link
Copy Markdown
Contributor Author

I still see a related error in last night's IB: https://cmssdt.cern.ch/SDT/cgi-bin/logreader/el9_amd64_gcc13/CMSSW_20_1_X_2026-08-09-2300/pyRelValMatrixLogs/run/34434.21_TTbar_14TeV+Run4D121_ProdLike/step4_TTbar_14TeV+Run4D121_ProdLike.log#/

I'm on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants