RecoMTD/TrackExtender: extract MTDHitMatcher standalone class by xabiercidvidal · Pull Request #51550 · cms-sw/cmssw

xabiercidvidal · 2026-07-23T12:15:53Z

PR description:

Continuation of the TrackExtenderWithMTD refactoring started in #51374.

Moves hit-matching logic out of TrackExtenderWithMTD and into a new standalone MTDHitMatcher class (analogous to TrackTransformer), exported as a library from RecoMTD/TrackExtender.

MTDHitMatcher owns the MeasurementEstimator, the TransientTrackingRecHit builder, and all chi²/bsTimeSpread configuration. It exposes:

matchBTL() — delegates to matchLayers() with allBTLLayers()
matchETL() — filters to same z-side, delegates to matchLayers(), sorts output innermost-first
matchLayers() (private) — the shared loop over find_hits_in_dets() and fillMatchingHits(); no logic duplication
The plugin config gains a nested "MTDHitMatcher" PSet (analogous to "TrackTransformer"), grouping: estimatorMaxChi2, estimatorMaxNSigma, btlChi2Cut, btlTimeChi2Cut, etlChi2Cut, etlTimeChi2Cut, bsTimeSpread, MTDRecHitBuilder.

TrackExtenderWithMTD::produce() now calls matcher_.matchBTL()/matchETL() with two lines each, making a planned intermediate BTL refit a one-line insertion between those two calls.

No logic changes.

PR validation:

PU200 RelMon (pr3 vs master+#51374, 827 MTD histograms, b2b KS t=0.99999): 827/827 passing (100%)

RelMon: https://cernbox.cern.ch/s/phGMV79uPHpJ5El
Overlay plots: https://cernbox.cern.ch/s/u96notA0FYngDv3

Move hit-matching logic out of TrackExtenderWithMTD and into a new standalone MTDHitMatcher class (analogous to TrackTransformer), exported as a library from RecoMTD/TrackExtender. MTDHitMatcher owns the MeasurementEstimator, the TransientTrackingRecHit builder, and all chi2/bsTimeSpread configuration. It exposes: matchBTL() -- delegates to matchLayers() with allBTLLayers() matchETL() -- filters to same z-side, delegates to matchLayers(), sorts output innermost-first matchLayers() (private) -- the shared loop over find_hits_in_dets() and fillMatchingHits(); no logic duplication The plugin config gains a nested "MTDHitMatcher" PSet (analogous to "TrackTransformer"), grouping: estimatorMaxChi2, estimatorMaxNSigma, btlChi2Cut, btlTimeChi2Cut, etlChi2Cut, etlTimeChi2Cut, bsTimeSpread, MTDRecHitBuilder. TrackExtenderWithMTD.produce() now calls matcher_.matchBTL/matchETL() with two lines each, making the planned PR5 intermediate BTL refit a one-line insertion between those two calls. No logic changes.

cmsbuild · 2026-07-23T12:16:17Z

cms-bot internal usage

cmsbuild · 2026-07-23T12:17:37Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51550/50276

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMTD/TrackExtender/BuildFile.xml modified in PR(s): Implementation of MTD track extender for muons #50029
- File RecoMTD/TrackExtender/plugins/BuildFile.xml modified in PR(s): Implementation of MTD track extender for muons #50029
- File RecoMTD/TrackExtender/plugins/TrackExtenderWithMTD.cc modified in PR(s): Implementation of MTD track extender for muons #50029, Aligning muon alignment code #51083

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51550/50276/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51550/50276/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-07-23T13:56:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51550/50277

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMTD/TrackExtender/BuildFile.xml modified in PR(s): Implementation of MTD track extender for muons #50029
- File RecoMTD/TrackExtender/plugins/BuildFile.xml modified in PR(s): Implementation of MTD track extender for muons #50029
- File RecoMTD/TrackExtender/plugins/TrackExtenderWithMTD.cc modified in PR(s): Implementation of MTD track extender for muons #50029, Aligning muon alignment code #51083

cmsbuild · 2026-07-23T13:57:10Z

A new Pull Request was created by @xabiercidvidal for master.

It involves the following packages:

RecoMTD/TrackExtender (reconstruction)

@Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2026-07-23T13:59:21Z

test parameters:

workflows = 34434.7522

mmusich · 2026-07-23T14:07:56Z

please test

cmsbuild · 2026-07-23T15:28:40Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cdbf4/54888/summary.html
COMMIT: 37960b2
CMSSW: CMSSW_20_1_X_2026-07-23-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51550/54888/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

34434.7522

----- Begin Fatal Exception 23-Jul-2026 17:25:36 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Validating configuration of module: class=TrackExtenderWithMTD label='hltTrackExtenderWithMTD'
Exception Message:
Illegal parameters found in configuration.  The parameters are named:
 'MTDRecHitBuilder'
 'bsTimeSpread'
 'btlChi2Cut'
 'btlTimeChi2Cut'
 'estimatorMaxChi2'
 'estimatorMaxNSigma'
 'etlChi2Cut'
 'etlTimeChi2Cut'
You could be trying to use parameter names that are not
allowed for this plugin, or they could be misspelled, or these parameters
need to be defined in the fillDescriptions() method of the plugin.
----- End Fatal Exception -------------------------------------------------

…cher PSet Move estimatorMaxChi2, estimatorMaxNSigma, btlChi2Cut, btlTimeChi2Cut, etlChi2Cut, etlTimeChi2Cut, bsTimeSpread and MTDRecHitBuilder into the nested MTDHitMatcher PSet introduced in RecoMTD/TrackExtender.

cmsbuild · 2026-07-23T20:56:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51550/50282

There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMTD/TrackExtender/BuildFile.xml modified in PR(s): Implementation of MTD track extender for muons #50029
- File RecoMTD/TrackExtender/plugins/BuildFile.xml modified in PR(s): Implementation of MTD track extender for muons #50029
- File RecoMTD/TrackExtender/plugins/TrackExtenderWithMTD.cc modified in PR(s): Implementation of MTD track extender for muons #50029, Aligning muon alignment code #51083

cmsbuild · 2026-07-23T20:56:36Z

Pull request #51550 was updated. @Martin-Grunewald, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @mmusich, @srimanob can you please check and sign again.

mmusich · 2026-07-24T05:33:48Z

@cmsbuild, please test

cmsbuild · 2026-07-24T07:35:53Z

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cdbf4/54893/summary.html
COMMIT: dbe77c1
CMSSW: CMSSW_20_1_X_2026-07-23-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51550/54893/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 5 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3596822
DQMHistoTests: Total failures: 92
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3596712
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 198 log files, 165 edm output root files, 46 DQM output files
TriggerResults: found differences in 2 / 45 workflows

mmusich · 2026-07-27T09:15:56Z

@cmsbuild, please test

to avoid spurious changes in the trigger results

cmsbuild · 2026-07-27T11:10:55Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0cdbf4/54938/summary.html
COMMIT: dbe77c1
CMSSW: CMSSW_20_1_X_2026-07-26-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51550/54938/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 1 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3596822
DQMHistoTests: Total failures: 21
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3596783
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 198 log files, 165 edm output root files, 46 DQM output files
TriggerResults: no differences found

mmusich · 2026-07-27T11:17:39Z

+hlt

Moanwar · 2026-08-04T15:40:53Z

+1

cmsbuild · 2026-08-04T15:41:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-08-04T19:24:16Z

+1

cmsbuild added this to the CMSSW_20_1_X milestone Jul 23, 2026

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jul 23, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jul 23, 2026

RecoMTD/TrackExtender: apply clang-format fixes

37960b2

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jul 23, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 23, 2026

cmsbuild added tests-started and removed tests-pending labels Jul 23, 2026

cmsbuild added tests-rejected and removed tests-started labels Jul 23, 2026

cmsbuild added hlt-pending tests-pending and removed tests-rejected code-checks-approved labels Jul 23, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 23, 2026

cmsbuild added tests-started and removed tests-pending labels Jul 24, 2026

cmsbuild added tests-approved and removed tests-started labels Jul 24, 2026

cmsbuild added tests-started and removed tests-approved labels Jul 27, 2026

cmsbuild added tests-approved and removed tests-started labels Jul 27, 2026

cmsbuild added hlt-approved and removed hlt-pending labels Jul 27, 2026

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Aug 4, 2026

cmsbuild added orp-approved and removed orp-pending labels Aug 4, 2026

cmsbuild merged commit 69f1d99 into cms-sw:master Aug 4, 2026
11 checks passed

cmsbuild mentioned this pull request Aug 5, 2026

METAlgorithms: Cleanup dependency to avoid linking TF for GenMETProducer #51632

Merged

Uh oh!

Conversation

xabiercidvidal commented Jul 23, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jul 23, 2026

Uh oh!

cmsbuild commented Jul 23, 2026

Uh oh!

cmsbuild commented Jul 23, 2026

Uh oh!

mmusich commented Jul 23, 2026

Uh oh!

mmusich commented Jul 23, 2026

Uh oh!

cmsbuild commented Jul 23, 2026

Failed RelVals

Uh oh!

cmsbuild commented Jul 23, 2026

Uh oh!

cmsbuild commented Jul 23, 2026

Uh oh!

mmusich commented Jul 24, 2026

Uh oh!

cmsbuild commented Jul 24, 2026

Comparison Summary

Uh oh!

mmusich commented Jul 27, 2026

Uh oh!

cmsbuild commented Jul 27, 2026

Comparison Summary

Uh oh!

mmusich commented Jul 27, 2026

Uh oh!

Moanwar commented Aug 4, 2026

Uh oh!

cmsbuild commented Aug 4, 2026

Uh oh!

mandrenguyen commented Aug 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented Jul 23, 2026 •

edited

Loading