TruthInfo: pileup-aware truth graph during mixing - #51470
Conversation
|
@cmsbuild please test |
|
cms-bot internal usage |
|
@cms-sw/generators-l2 could you please review and sign? this is needed for the sample production. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51470/50168 |
|
A new Pull Request was created by @felicepantaleo for master. It involves the following packages:
@lviliani, @mkirsano, @sensrcn, @theofil can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
-1 Failed Tests: Build ClangBuild The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed BuildI found compilation error when building: ------- copying files from src/PhysicsTools/TruthInfo/scripts -------
>> copied makeTruthGraphValidationPlots.py
>> Compiling src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t.cpp
/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/gcc/13.4.0-6908cfdf803923e783448096ca4f0923/bin/c++ -c -DCMS_MICRO_ARCH='x86-64-v3' -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=130400 -DTBB_SUPPRESS_DEPRECATED_MESSAGES -DTBB_PREVIEW_RESUMABLE_TASKS=1 -DTBB_PREVIEW_TASK_GROUP_EXTENSIONS=1 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DBOOST_MATH_DISABLE_STD_FPCLASSIFY -DBOOST_UUID_RANDOM_PROVIDER_FORCE_POSIX -DBOOST_MPL_IGNORE_PARENTHESES_WARNING -DCMSSW_GIT_HASH='CMSSW_20_1_X_2026-07-12-0000' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_20_1_X_2026-07-12-0000' -Isrc -Ipoison -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/cms/cmssw/CMSSW_20_1_X_2026-07-12-0000/src -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/hepmc3/3.3.1-0e3a14abf956ab6455e0a82d19f54f77/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/pcre/8.43-7f0edb13c32a66555b25b5433dd2ceed/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/boost/1.91.0-4eabf1c007e1fd684a3ea24705495812/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/bz2lib/1.0.8-353e2ef1c2f1d06b28a8938defa197bc/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/clhep/2.4.7.2-4a01a851ada8a481b4c8f9856a60bb0b/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/cppunit/1.15.x-08da40e4de8fd94fcb7bac1dce1b87fc/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/gsl/2.6-f7a733435831708073d54bcef0bb3ab2/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/hepmc/2.06.10-00a0d35b3057f230b67188fb41fc8f5e/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/heppdt/3.04.01-aa4f6cddf7c53decf34691f13b2307b1/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/hls/2025.05-1e9bc123eaf0d9d12de4203b234629e6/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/libuuid/2.40-d94705b84648fd294d63bf9de23bc03b/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/lcg/root/6.36.13-1e2cf577544a16a0d90570e219cd8156/include -isystem/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/tbb/v2022.3.0-dc50d53ffc8b6a202ff6e276cd3c9d79/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/xz/5.6.4-ea99661ac7ca423b4d74fd650284b41f/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/zlib/1.3.2-53c061acc706fe8f28fd9477d9981c20/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/zstd/1.5.7-3d33d105dce0061a2affabfbb156d655/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/alpaka/2.1.1-3caaac8d71f39d400ab2511b2403675a/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/eigen/c1d637433e3b3f9012b226c2c9125c494b470ae6-64a84c2742d1bb0d777807c58fc50caf/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/eigen/c1d637433e3b3f9012b226c2c9125c494b470ae6-64a84c2742d1bb0d777807c58fc50caf/include/eigen3 -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/fmt/10.2.1-2fdb9573b12b6a8373d9a65eba3c8c59/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/md5/1.0.0-26057075013e190e56dad37d35219376/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/OpenBLAS/0.3.27-47a3c8350874a1ad9f41674752b30581/include -I/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02950/el9_amd64_gcc13/external/tinyxml2/6.2.0-da2efb8ba86adb2f29c708e411784949/include -O3 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++20 -ftree-vectorize -Werror=array-bounds -Werror=format-contains-nul -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -Wno-error=array-bounds -Warray-bounds -fuse-ld=bfd -march=x86-64-v3 -felide-constructors -fmessage-length=0 -Wall -Wno-non-template-friend -Wno-long-long -Wreturn-type -Wextra -Wpessimizing-move -Wclass-memaccess -Wno-cast-function-type -Wno-unused-but-set-parameter -Wno-ignored-qualifiers -Wno-unused-parameter -Wunused -Wparentheses -Werror=return-type -Werror=unused-value -Werror=unused-result -Werror=unused-label -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=unused-but-set-variable -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=return-local-addr -Wnon-virtual-dtor -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-psabi -DEIGEN_DONT_PARALLELIZE -DEIGEN_MAX_ALIGN_BYTES=64 -DALPAKA_DEFAULT_HOST_MEMORY_ALIGNMENT=128 -DALPAKA_DISABLE_VENDOR_RNG -DALPAKA_HAS_STD_ATOMIC_REF -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -flto=auto -fipa-icf -flto-odr-type-merging -fno-fat-lto-objects -Wodr -fPIC -MMD -MF tmp/el9_amd64_gcc13/src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t/BranchHitAssociator_t.cpp.d src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t.cpp -o tmp/el9_amd64_gcc13/src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t/BranchHitAssociator_t.cpp.o
src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t.cpp: In function 'truth::LogicalGraphHitIndex {anonymous}::buildIndex()':
src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t.cpp:29:29: error: no matching function for call to 'truth::LogicalGraphHitIndexBuilder::setSimTrackForParticle(int, int)'
29 | b.setSimTrackForParticle(0, 100);
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
In file included from src/PhysicsTools/TruthInfo/test/BranchHitAssociator_t.cpp:12:
src/PhysicsTools/TruthInfo/interface/LogicalGraphHitIndexBuilder.h:23:10: note: candidate: 'void truth::LogicalGraphHitIndexBuilder::setSimTrackForParticle(uint32_t, uint64_t, uint32_t)'
23 | void setSimTrackForParticle(uint32_t particleId, uint64_t eventId, uint32_t trackId);
Failed Clang BuildI found compilation error while trying to compile with clang. Command used: >> Entering Package SimG4Core/Application >> Entering Package SimG4Core/Notification >> Entering Package PhysicsTools/TruthInfo >> Entering Package SimDataFormats/TruthInfo >> Compile sequence completed for CMSSW CMSSW_20_1_X_2026-07-12-0000 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 Command exited with non-zero status 1 Command being timed: "scram build -k -j 32 COMPILER=llvm compile BUILD_LOG=yes" User time (seconds): 349.25 System time (seconds): 43.22 Percent of CPU this job got: 1291% |
77b81cd to
de552de
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51470/50169 |
de552de to
374fdae
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51470/50170 |
|
@cmsbuild please test |
|
-1 Failed Tests: UnitTests The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Failed Unit TestsI found 3 errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS ---> test TestDQMGUIUpload had ERRORS ---> test TestDQMCompareHistogram had ERRORS Comparison SummarySummary:
|
|
@cmsbuild please test |
|
urgent |
|
+1 Size: This PR adds an extra 52KB to repository Comparison SummarySummary:
|
|
urgent |
|
@cms-sw/generators-l2 please have a look |
|
+generators |
cmsbuild
added
generators-approved
fully-signed
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
done, #51487 |
…_production_CMSSW_20 TruthInfo: pileup-aware truth graph during mixing
4 participants
Accumulate merged HGCal, barrel ECAL/HCAL and tracker/muon/MTD pileup sim-hits in the TruthGraphAccumulator so the mixed truth graph carries pileup hit coverage. Resolve pileup hit coverage, namespace the hit-index trackId by EncodedEventId for mixed graphs, and capture tracking-detector hits only on opt-in (calo-only default). Adds the mixing customizes for pileup-aware reco. This is needed for DIGI step in production, when mixing signal with PU, both generated with the truth graph.
To be backported to CMSSW_20_0_X
@Moanwar fyi