Add scouting to Phase-2 HLT menu - #51424
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51424/50085
|
There was a problem hiding this comment.
Pull request overview
This PR enables the existing DST_PFScouting HLT path in the Phase-2 HLT_75e33 menu by loading the path fragment and adding the path to the menu schedule, so it runs and appears in TriggerResults for that menu configuration.
Changes:
- Load
HLTrigger/Configuration/HLT_75e33/paths/DST_PFScouting_cfiin theHLT_75e33_cff.pyfragment. - Add
fragment.DST_PFScoutingtofragment.scheduleso the path is actually executed.
Comments suppressed due to low confidence (1)
HLTrigger/Configuration/python/HLT_75e33_cff.py:281
- There is stray whitespace on the blank line after adding
fragment.DST_PFScoutingto the schedule (line contains indentation spaces only). This can create avoidable diff noise and may trip whitespace/formatting checks; keep the blank line empty (or remove it).
fragment.load("HLTrigger/Configuration/HLT_75e33/sequences/HLTVertexRecoSequence_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/services/DQMStore_cfi")
fragment.load("HLTrigger/Configuration/HLT_75e33/services/FastTimerService_cfi")
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
A new Pull Request was created by @silviodonato for master. It involves the following packages:
@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
test parameters:
|
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 28KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see more details here: Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
@silviodonato can you please rebase to get rid of the merge commit? |
|
@silviodonato I want to make sure I understand how this fits with the NGT Scouting plans. The path here looks like the current NGT variant, where we've been assuming we'd keep a lot of freedom in the reconstruction approach. Promoting it as "standard scouting" raises a question for me about how that flexibility is preserved going forward — could you say a bit about how you're thinking about the scope? Keen to find a framing that works for both the menu and NGT. |
My minimal proposal would be to duplicate the paths, call the one used in the |
|
Phase-2 scouting is part of the standard CMS program, so I think it is normal to have Probably the misunderstanding comes from
I thought in |
As a matter of fact we do, and the NGT-specific sequences are achieved via process modifiers (namely |
…ting in HLT_NGTScouting_cff.py
943cd7d to
27cb1b0
Compare
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51424/50120
|
|
Pull request #51424 was updated. @Martin-Grunewald, @cmsbuild, @ctarricone, @gabrielmscampos, @mmusich, @rseidita can you please check and sign again. |
|
Thanks for spotting it. I checked that there are no other mention of |
|
@cmsbuild, please test |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
this is expected because of the path renaming.
it looks like most of the failures come from the fact that now tau reconstruction runs "unseeded" due to the scouting path, which I think it's reasonable as the other MC paths already reconstructed most of the physics objects in an unseeded way. |
|
+hlt
|
|
+dqm |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Add scouting to Phase-2 HLT menu
PR description:
As discussed at the TSG coordination meetings [1] and [2], here a PR to add scouting to the Phase-2 HLT menu.
As this scouting will reconstruct almost all HLT objects in all events, it will be added only to
HLT_75e33_cff.py, and not toHLT_75e33_timing_cff.py.Note that in
HLT_75e33_cff.pywe are already reconstructing tracks and unseeded electrons in all events or so (seeMC_TRKandMC_Ele5_Open_Unseeded), so I do not expect a big increase in timing of step2 due to this PRPR validation:
I ran
in
CMSSW_20_0_0_pre1with and without the changes. I checked that after the change the trigger bitDST_PFScoutingappearedIf this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No backport requested (as the 20_0_X production is supposed to start very soon)