Skip to content

Disable MC-based TSG tests in 20_0_X - #51151

Merged
cmsbuild merged 2 commits into
cms-sw:CMSSW_20_0_Xfrom
cms-tsg-storm:disable_test_20_0_X
Jun 10, 2026
Merged

Disable MC-based TSG tests in 20_0_X#51151
cmsbuild merged 2 commits into
cms-sw:CMSSW_20_0_Xfrom
cms-tsg-storm:disable_test_20_0_X

Conversation

@mmusich

@mmusich mmusich commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

backport of #51188
backport of #51141

PR description:

Title says it all, since when master moved to CMSSW_2_0_X several MC-based TSG integration tests have been failing due to the change in the data-format layout introduced in #50968.
The goal of this PR is to disable the failing tests log1, log2.

PR validation:

To be tested by the bot.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Verbatim backport of #51141 to CMSSW_20_0_X

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for CMSSW_20_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@mmusich mmusich changed the title Disable MC-based TSG tests in 20_1_X Disable MC-based TSG tests in 20_0_X Jun 9, 2026
@mmusich

mmusich commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

test parameters:

  • enable = hlt_p2_timing

@mmusich

mmusich commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4422dd/53766/summary.html
COMMIT: 1a34013
CMSSW: CMSSW_20_0_X_2026-06-08-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51151/53766/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 30
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248342
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@cmsbuild

cmsbuild commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_20_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

Comment thread HLTrigger/Configuration/test/runAll.csh Outdated
@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #51151 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@mmusich

mmusich commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

The last version was tested successfully using the following recipe:

#!/bin/bash -ex
cd $CMSSW_BASE/src/HLTrigger/Configuration/test/
./runAll.csh IB | tee -a runIB.log 
./examLogs.csh | tee -a examLogs.out

following the same logic as the bot

@mmusich

mmusich commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4422dd/53840/summary.html
COMMIT: 5c16766
CMSSW: CMSSW_20_0_X_2026-06-10-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51151/53840/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248372
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

+hlt

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_20_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 8c78d70 into cms-sw:CMSSW_20_0_X Jun 10, 2026
10 checks passed
@mmusich
mmusich deleted the disable_test_20_0_X branch June 10, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants