[ALCA-DB] Drop Geometry/CommonDetUnit package - #51075
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51075/49528
|
|
A new Pull Request was created by @smuzaffar for master. It involves the following packages:
@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
@smuzaffar why not to profit of this PR to also remove the Geometry/CommonDetUnit package at all? |
@perrotta , currently all of these PRs are independent and go in as soon as they are signed. I will open a PR to drop the |
|
+1 Size: This PR adds an extra 812KB to repository Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
+1
|
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
…Unit [ALCA-DB] Drop Geometry/CommonDetUnit package
In order to avoid cyclic dependency (#28415) we had merged
Geometry/CommonDetUnitin toGeometry/CommonTopologies(#28500) . This PR is to cleanup the usage ofGeometry/CommonDetUnit