Skip to content

[ALCA-DB] Drop Geometry/CommonDetUnit package - #51075

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:alca-db-drop-CommonDetUnit
May 30, 2026
Merged

[ALCA-DB] Drop Geometry/CommonDetUnit package#51075
cmsbuild merged 1 commit into
cms-sw:masterfrom
smuzaffar:alca-db-drop-CommonDetUnit

Conversation

@smuzaffar

Copy link
Copy Markdown
Contributor

In order to avoid cyclic dependency (#28415) we had merged Geometry/CommonDetUnit in to Geometry/CommonTopologies (#28500) . This PR is to cleanup the usage of Geometry/CommonDetUnit

@cmsbuild

cmsbuild commented May 28, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51075/49528

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for master.

It involves the following packages:

  • Alignment/APEEstimation (alca)
  • Alignment/CommonAlignment (alca)
  • Alignment/CommonAlignmentAlgorithm (alca)
  • Alignment/CommonAlignmentMonitor (alca)
  • Alignment/CommonAlignmentProducer (alca)
  • Alignment/LaserAlignment (alca)
  • Alignment/LaserAlignmentSimulation (alca)
  • Alignment/MillePedeAlignmentAlgorithm (alca)
  • Alignment/MuonAlignment (alca)
  • Alignment/MuonAlignmentAlgorithms (alca)
  • Alignment/OfflineValidation (alca)
  • Alignment/ReferenceTrajectories (alca)
  • Alignment/SurveyAnalysis (alca)
  • Alignment/TrackerAlignment (alca)
  • CalibFormats/SiStripObjects (alca)
  • CalibTracker/SiPhase2TrackerESProducers (alca)
  • CalibTracker/SiPixelConnectivity (alca)
  • CalibTracker/SiPixelESProducers (alca)
  • CalibTracker/SiPixelErrorEstimation (alca)
  • CalibTracker/SiPixelLorentzAngle (alca)
  • CalibTracker/SiPixelQuality (alca)
  • CalibTracker/SiPixelTools (alca)
  • CalibTracker/SiStripChannelGain (alca)
  • CalibTracker/SiStripCommon (alca)
  • CalibTracker/SiStripESProducers (alca)
  • CalibTracker/SiStripHitEfficiency (alca)
  • CalibTracker/SiStripHitResolution (alca)
  • CalibTracker/SiStripLorentzAngle (alca)
  • CalibTracker/StandaloneTrackerTopology (alca)
  • Calibration/HcalCalibAlgos (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • CondFormats/SiPixelObjects (alca, db)
  • CondTools/SiPhase2Tracker (alca)
  • CondTools/SiPixel (db)
  • CondTools/SiStrip (db)

@Alejandro1400, @JanChyczynski, @arunhep, @atpathak, @cmsbuild, @francescobrivio, @perrotta can you please review it and eventually sign? Thanks.
@24LopezR, @CeliaFernandez, @JanChyczynski, @PonIlya, @ReyerBand, @VinInn, @abbiendi, @alesaggio, @argiro, @bsunanda, @dkotlins, @echabert, @ferencek, @fsimone91, @gbenelli, @jhgoh, @llunerti, @missirol, @mmusich, @mroguljic, @pakhotin, @rchatter, @robervalwalsh, @rsreds, @seemasharmafnal, @thomreis, @threus, @tlampen, @tocheng, @trocino, @tsusa, @wang0jin, @yuanchao this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test

@perrotta

Copy link
Copy Markdown
Contributor

@smuzaffar why not to profit of this PR to also remove the Geometry/CommonDetUnit package at all?

@smuzaffar

smuzaffar commented May 28, 2026

Copy link
Copy Markdown
Contributor Author

@smuzaffar why not to profit of this PR to also remove the Geometry/CommonDetUnit package at all?

@perrotta , currently all of these PRs are independent and go in as soon as they are signed. I will open a PR to drop the Geometry/CommonDetUnit package once all of these are merged

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 812KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-715e39/53532/summary.html
COMMIT: 993d9d5
CMSSW: CMSSW_17_0_X_2026-05-28-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51075/53532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 36
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198421
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 2025.0010001_RunJetMET02025C_10k step2 max memory diff 25.4 exceeds +/- 10.0 MiB

@perrotta

Copy link
Copy Markdown
Contributor

+1

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 0a3fdcf into cms-sw:master May 30, 2026
10 checks passed
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 25, 2026
…Unit

[ALCA-DB] Drop Geometry/CommonDetUnit package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants