add hybrid PU workflow to PR tests by kpedro88 · Pull Request #51022 · cms-sw/cmssw

kpedro88 · 2026-05-22T16:52:16Z

PR description:

Now that the hybrid PU implementation is in the master branch (#50886), the workflow should be tested routinely. I have added one of the example workflows into the short matrix for PR tests.

I also dealt with these syntax warnings emitted by Python 3.12:

src/Configuration/PyReleaseValidation/python/WorkFlowRunner.py:71: SyntaxWarning: invalid escape sequence '\.'
  file_pattern_step = re.compile('file:step([1-9]+)(_[a-zA-Z]+)?\.[a-z]+')
src/Configuration/PyReleaseValidation/python/relval_steps.py:3889: SyntaxWarning: invalid escape sequence '\)'
  'extend_file_name(process.ALCARECOStreamPromptCalibProdSiPixelAliHLTHGC.fileName.value(), \\"_0\\"\"\)',
src/Configuration/PyReleaseValidation/python/relval_steps.py:3910: SyntaxWarning: invalid escape sequence '\)'
  'extend_file_name(process.ALCARECOStreamPromptCalibProdSiPixelAliHLTHGC.fileName.value(), \\"_1\\"\"\)',

(probably there should be a larger campaign to check for these; I only dealt with this one package)

attn: @civanch @subirsarkar @suchandradutta @bsunanda

PR validation:

runTheMatrix.py -l 17034.96 succeeds.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cmsbuild · 2026-05-22T16:52:42Z

cms-bot internal usage

cmsbuild · 2026-05-22T16:54:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51022/49460

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954, Displaced Particle Gun #51006
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): [Do not merge] For cms-bot PR testing #48637, Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954, [NGT] Add workflow to produce Phase2 NANOAOD with L1 and HLT objects #51004

cmsbuild · 2026-05-22T16:55:15Z

A new Pull Request was created by @kpedro88 for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv)

@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @makortel, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

kpedro88 · 2026-05-22T17:00:52Z

please test

cmsbuild · 2026-05-22T19:20:01Z

+1

Size: This PR adds an extra 84KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-740f94/53446/summary.html
COMMIT: 336b5ba
CMSSW: CMSSW_17_0_X_2026-05-22-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51022/53446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4198477
DQMHistoTests: Total failures: 68
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4198389
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

kpedro88 · 2026-05-27T22:05:51Z

@cms-sw/pdmv-l2 please sign

kpedro88 · 2026-06-01T16:31:58Z

@cms-sw/pdmv-l2 please sign

AdrianoDee · 2026-06-01T16:45:55Z

@kpedro88 can you add a line in the table in https://github.com/kpedro88/cmssw/blob/336b5ba390b3ecae734a60907fea2b4efe2e834f/Configuration/PyReleaseValidation/scripts/README.md? Thanks.

kpedro88 · 2026-06-01T17:04:57Z

@AdrianoDee there are quite a few entries missing from that table. I updated the 2025 section but did not go through the other years exhaustively.

cmsbuild · 2026-06-01T17:06:05Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51022/49601

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954, Displaced Particle Gun #51006
- File Configuration/PyReleaseValidation/scripts/runTheMatrix.py modified in PR(s): [Do not merge] For cms-bot PR testing #48637, Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954, [NGT] Add workflow to produce Phase2 NANOAOD with L1 and HLT objects #51004

cmsbuild · 2026-06-01T17:06:29Z

Pull request #51022 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please check and sign again.

kpedro88 · 2026-06-01T17:06:46Z

please test

AdrianoDee · 2026-06-01T17:23:31Z

+pdmv

tests successful with 336b5ba
90d062b is only documentation

cmsbuild · 2026-06-01T17:23:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @ftenchini, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2026-06-01T23:06:14Z

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-740f94/53626/summary.html
COMMIT: 90d062b
CMSSW: CMSSW_17_0_X_2026-06-01-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51022/53626/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 5 lines from the logs
Reco comparison results: 24 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4199113
DQMHistoTests: Total failures: 69
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4199024
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

mandrenguyen · 2026-06-02T08:21:16Z

+1

add hybrid PU workflow to PR tests

kpedro88 added 2 commits May 22, 2026 10:54

fix syntax errors

9c51c7e

add hybrid PU workflow to PR tests

336b5ba

cmsbuild added this to the CMSSW_17_0_X milestone May 22, 2026

cmsbuild added pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending labels May 22, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 22, 2026

cmsbuild added tests-started and removed tests-pending labels May 22, 2026

cmsbuild added tests-approved and removed tests-started labels May 22, 2026

cmsbuild mentioned this pull request May 26, 2026

Remove Run 1-3 and disable Phase 2 RelVal workflows that read existing non-RAW files #50954

Merged

cmsbuild mentioned this pull request May 28, 2026

Displaced Particle Gun #51006

Merged

update short matrix table

90d062b

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jun 1, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 1, 2026

cmsbuild added tests-started and removed tests-pending labels Jun 1, 2026

cmsbuild added fully-signed pdmv-approved and removed pending-signatures pdmv-pending labels Jun 1, 2026

cmsbuild added tests-approved and removed tests-started labels Jun 1, 2026

cmsbuild added orp-approved and removed orp-pending labels Jun 2, 2026

cmsbuild merged commit 102a2fe into cms-sw:master Jun 2, 2026
10 checks passed

NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 25, 2026

Merge pull request cms-sw#51022 from kpedro88/Phase2-WF85

75043a2

add hybrid PU workflow to PR tests

Uh oh!

Conversation

kpedro88 commented May 22, 2026

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 22, 2026

Uh oh!

cmsbuild commented May 22, 2026

Uh oh!

kpedro88 commented May 22, 2026

Uh oh!

cmsbuild commented May 22, 2026

Comparison Summary

Uh oh!

kpedro88 commented May 27, 2026

Uh oh!

kpedro88 commented Jun 1, 2026

Uh oh!

AdrianoDee commented Jun 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kpedro88 commented Jun 1, 2026

Uh oh!

cmsbuild commented Jun 1, 2026

Uh oh!

cmsbuild commented Jun 1, 2026

Uh oh!

kpedro88 commented Jun 1, 2026

Uh oh!

AdrianoDee commented Jun 1, 2026

Uh oh!

cmsbuild commented Jun 1, 2026

Uh oh!

cmsbuild commented Jun 1, 2026

Comparison Summary

Uh oh!

mandrenguyen commented Jun 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented May 22, 2026 •

edited

Loading

AdrianoDee commented Jun 1, 2026 •

edited

Loading