Gtt jet finding geometry readout by ccahoughton · Pull Request #50908 · cms-sw/cmssw

ccahoughton · 2026-05-08T16:13:28Z

PR description:

Added valid bit to TkJetWord object
TkJetWord now contains 64 bits of data as opposed to 63 before
Changed track jet ordering on readout to GTT pattern file to reflect the same order as the firmware (was sorted by pT before, now sorted first by phi then by eta)
Added extra output file when running createFirmwareInputFiles_cfg.py called FirmwareGeometryFile.vh. If any of the JetFinding parameters change like eta bin centers or cuts on track multiplicity, regenerate FirmwareGeometryFile.vh and place it in the /algo/components/jet/firmware/hdl/ directory of the JetFinding firmware.
Presentation of changes in a talk coming soon

PR validation:

Valid bit present in track jet words in GTT test vector files
Used FirmwareGeometryFile.vh in the firmware and checked emulator test vector output against firmware. They match.

cmsbuild · 2026-05-08T16:13:56Z

cms-bot internal usage

cmsbuild · 2026-05-08T16:15:46Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49269

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py modified in PR(s): W3Pi Emulation and Test Vectors #49003

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49269/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49269/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2026-05-08T16:31:51Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49271

There are other open Pull requests which might conflict with changes you have proposed:
- File L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py modified in PR(s): W3Pi Emulation and Test Vectors #49003

cmsbuild · 2026-05-08T16:32:15Z

A new Pull Request was created by @ccahoughton for master.

It involves the following packages:

DataFormats/L1Trigger (l1)
L1Trigger/DemonstratorTools (l1)
L1Trigger/L1TTrackMatch (l1)

@BenjaminRS, @cmsbuild, @quinnanm can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @eyigitba, @missirol, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

quinnanm · 2026-05-08T16:46:55Z

please test

cmsbuild · 2026-05-08T18:41:38Z

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5cf094/53153/summary.html
COMMIT: 8bc438b
CMSSW: CMSSW_17_0_X_2026-05-08-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50908/53153/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 53
DQMHistoTests: Total histograms compared: 4187168
DQMHistoTests: Total failures: 60
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 4187088
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
Checked 227 log files, 197 edm output root files, 53 DQM output files
TriggerResults: no differences found

BenjaminRS · 2026-05-13T14:42:41Z

Hi Connor - to let you know. PR #49003 will soon be closed and this also modified L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py. So I suggest we wait until that one is in and we will ask you to rebase on-top of that PR. In the mean time we can review the other files modified.

quinnanm

Thank you for this PR! Just a few comments so far.

quinnanm · 2026-05-19T00:17:15Z

    // ----------constants, enums and typedefs ---------
    static constexpr double MAX_Z0 = 30.;
-    static constexpr double MAX_ETA = 8.;
+    static constexpr double MAX_ETA = 2 * M_PI;


Why is max eta 2pi?

This comes from the GTT interface document specifying that the max eta for the prompt jet word is 2*pi (see attached screenshot)

quinnanm · 2026-05-19T00:20:56Z

+                                       int minTrkJetTrackMultiplicity_,
+                                       float minTrkJetpT_) {
+    ofstream FirmwareGeometryFile;
+    FirmwareGeometryFile.open("./FirmwareGeometryFile.vh");


May be useful add a check here to make sure the file is open

Okay, I put in a simple solution:

if (FirmwareGeometryFile.is_open()) {
...
...
...
} else {
std::cout << "Failed to open firmware geometry export file" << std::endl;
}

Let me know if you had something else in mind!

quinnanm · 2026-05-19T00:26:27Z

+    //out as bit words to the geometry file
+    for (int i = 0; i < etaBins_; i++) {
+      unsigned int EtaBitInt = DoubleToBit(
+          eta_bin_centers[i], l1t::TkJetWord::TkJetBitWidths::kGlbEtaSize, l1t::TkJetWord::MAX_ETA * pow(2, -13));


Should l1t::TkJetWord::MAX_ETA * pow(2, -13) be derived from kGlbEtaSize to avoid magic numbers? For example: (2 * MAX_ETA) / (1 << kGlbEtaSize)

Yes, I will change it.

quinnanm · 2026-05-19T00:31:37Z

+        DoubleToBit(double(mzb.clusters[j].eta),
+                    TkJetWord::TkJetBitWidths::kGlbEtaSize,
+                    2 * TkJetWord::MAX_ETA / (1 << TkJetWord::TkJetBitWidths::kGlbEtaSize));
+    // TkJetWord::MAX_ETA / (1 << TkJetWord::TkJetBitWidths::kGlbEtaSize));


could this comment be removed?

Yes, I will remove it.

cmsbuild · 2026-06-05T16:37:14Z

Milestone for this pull request has been moved to CMSSW_20_0_X. Please open a backport if it should also go in to CMSSW_17_0_X.

makortel · 2026-06-05T18:39:28Z

Just checking, is this PR intended for Phase 2 (20_1_X) or Run 3 legacy (17_0_X) or both?

cmsbuild · 2026-06-05T19:21:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-50908/49647

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/L1Trigger/interface/TkJetWord.h modified in PR(s): Move stored types in io_v1 namespace, reset class versions to 3 #50968
- File L1Trigger/DemonstratorTools/test/gtt/createFirmwareInputFiles_cfg.py modified in PR(s): W3Pi Emulation and Test Vectors #49003

cmsbuild · 2026-06-05T19:22:12Z

Pull request #50908 was updated. @BenjaminRS, @cmsbuild, @quinnanm can you please check and sign again.

quinnanm · 2026-06-08T20:50:22Z

this is intended for Phase 2 (20_1_X)

makortel · 2026-06-08T21:59:41Z

Thanks. Then no further action is needed for this PR regarding the target branch.

cmsbuild · 2026-06-09T07:27:49Z

Milestone for this pull request has been moved to CMSSW_20_1_X. Please open a backport if it should also go in to CMSSW_20_0_X.

ccahoughton added 3 commits May 8, 2026 10:00

Emulator/Firmware consistency changes

3147046

Emulator/Firmware consistency changes 2

bb334a1

Emulator/Firmware consistency changes 3

b07b660

cmsbuild added this to the CMSSW_17_0_X milestone May 8, 2026

cmsbuild added l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels May 8, 2026

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 8, 2026

Fixed comment space

8bc438b

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 8, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels May 8, 2026

cmsbuild added tests-started and removed tests-pending labels May 8, 2026

cmsbuild added tests-approved and removed tests-started labels May 8, 2026

cmsbuild mentioned this pull request May 18, 2026

Move stored types in io_v1 namespace, reset class versions to 3 #50968

Merged

quinnanm reviewed May 19, 2026

View reviewed changes

cmsbuild mentioned this pull request May 22, 2026

Update NNVtx emulator to match latest HW #51008

Open

cmsbuild modified the milestones: CMSSW_17_0_X, CMSSW_20_0_X Jun 5, 2026

Review changes

6fbb33b

cmsbuild added tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jun 5, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 5, 2026

cmsbuild modified the milestones: CMSSW_20_0_X, CMSSW_20_1_X Jun 9, 2026

cmsbuild mentioned this pull request Jun 12, 2026

W3Pi Emulation and Test Vectors #49003

Open

Uh oh!

Conversation

ccahoughton commented May 8, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented May 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented May 8, 2026

Uh oh!

cmsbuild commented May 8, 2026

Uh oh!

cmsbuild commented May 8, 2026

Uh oh!

quinnanm commented May 8, 2026

Uh oh!

cmsbuild commented May 8, 2026

Comparison Summary

Uh oh!

BenjaminRS commented May 13, 2026

Uh oh!

quinnanm left a comment

Choose a reason for hiding this comment

Uh oh!

quinnanm May 19, 2026

Choose a reason for hiding this comment

Uh oh!

ccahoughton May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

quinnanm May 19, 2026

Choose a reason for hiding this comment

Uh oh!

ccahoughton May 28, 2026

Choose a reason for hiding this comment

Uh oh!

quinnanm May 19, 2026

Choose a reason for hiding this comment

Uh oh!

ccahoughton May 19, 2026

Choose a reason for hiding this comment

Uh oh!

quinnanm May 19, 2026

Choose a reason for hiding this comment

Uh oh!

ccahoughton May 19, 2026

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Jun 5, 2026

Uh oh!

makortel commented Jun 5, 2026

Uh oh!

cmsbuild commented Jun 5, 2026

Uh oh!

cmsbuild commented Jun 5, 2026

Uh oh!

quinnanm commented Jun 8, 2026

Uh oh!

makortel commented Jun 8, 2026

Uh oh!

cmsbuild commented Jun 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cmsbuild commented May 8, 2026 •

edited

Loading

ccahoughton May 19, 2026 •

edited

Loading