Skip to content

Add typedef of ProductDependencies to dictionary generation - #50683

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:rootTypedefProductDependencies
Apr 9, 2026
Merged

Add typedef of ProductDependencies to dictionary generation#50683
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:rootTypedefProductDependencies

Conversation

@Dr15Jones

@Dr15Jones Dr15Jones commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

PR description:

In ROOT 6.39 the RNTuple tests fail without the typedef.

PR validation:

Code compiled and tested using experimental build of newest ROOT. See cms-sw/cmsdist#10475

resolves cms-sw/framework-team#2143

In ROOT 6.39 the RNTuple tests fail without the typedef.
@Dr15Jones

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • DataFormats/Provenance (core)

@Dr15Jones, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @missirol, @mmusich, @rovere, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-792550/52523/summary.html
COMMIT: 9cba588
CMSSW: CMSSW_17_0_X_2026-04-07-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/50683/52523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4180749
  • DQMHistoTests: Total failures: 44
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4180685
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@makortel

makortel commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Comparison differences are related to #47071

@makortel

makortel commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

Also in the default ROOT 6.36 based build the .rootmap file gets

typedef edm::ProductDependencies

@makortel

makortel commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

+core

@cmsbuild

cmsbuild commented Apr 8, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit c719781 into cms-sw:master Apr 9, 2026
10 checks passed
@Dr15Jones
Dr15Jones deleted the rootTypedefProductDependencies branch May 18, 2026 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ROOT 6.39 RNTuple issue with missing typedef

4 participants