Skip to content

Modify Tool_DependencyCudaDLINK for conditional linking - #119

Merged
smuzaffar merged 1 commit into
scramv3from
smuzaffar-patch-1
Jul 15, 2026
Merged

Modify Tool_DependencyCudaDLINK for conditional linking#119
smuzaffar merged 1 commit into
scramv3from
smuzaffar-patch-1

Conversation

@smuzaffar

Copy link
Copy Markdown
Contributor

Follow up on #118

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for branch scramv3.

@akritkbehera, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@slava77

slava77 commented Jul 14, 2026

Copy link
Copy Markdown

I checked in a local test that this update no longer creates a second LSTEvent_dev_cc definition (nm -C -l ../lib/$SCRAM_ARCH/pluginRecoTrackerLSTPluginsPortableCudaAsync.so | grep _LSTEvent_dev_cc_ has no match)

vs the baseline

nm -C -l $CMSSW_RELEASE_BASE/lib/$SCRAM_ARCH/libRecoTrackerLSTCoreCudaAsync.so | grep _LSTEvent_dev_cc_
0000000003e7dd0d r def_module_id_str_25cecf85_15_LSTEvent_dev_cc_2318a074_805189

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c1c5/54745/summary.html
COMMIT: 226b8e7
CMSSW: CMSSW_20_1_X_2026-07-14-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c1c5/54745/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c1c5/54745/git-merge-result

Failed RelVals

----- Begin Fatal Exception 14-Jul-2026 19:09:11 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTorchClassifier/model.pt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/external/el9_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Mixins.py(402): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Mixins.py(537): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 14-Jul-2026 19:09:12 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTorchClassifier/model.pt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/external/el9_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34496.0_CloseByPGun_CE_E_Front_120um+Run4D121


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Mixins.py(402): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Mixins.py(537): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 14-Jul-2026 19:10:38 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoTracker/FinalTrackSelectors/data/TrackTorchClassifier/model.pt anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/external/el9_amd64_gcc13/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/34434.0_TTbar_14TeV+Run4D121


At:
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Mixins.py(402): insertContentsInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Mixins.py(537): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Config.py(1120): _insertManyInto
  /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54745/CMSSW_20_1_X_2026-07-14-1100/src/FWCore/ParameterSet/python/Config.py(1331): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84c1c5/54768/summary.html
COMMIT: 226b8e7
CMSSW: CMSSW_20_1_X_2026-07-15-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/119/54768/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 166 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3548294
  • DQMHistoTests: Total failures: 67
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3548209
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor Author

+externals

@smuzaffar
smuzaffar merged commit 1aabb9c into scramv3 Jul 15, 2026
8 checks passed
@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants