Skip to content

Updated TOoLLiP to version 3.1.0. - #10591

Merged
smuzaffar merged 1 commit into
cms-sw:IB/CMSSW_20_1_X/masterfrom
Brainz22:toollip-v3-1-0
Jun 10, 2026
Merged

Updated TOoLLiP to version 3.1.0.#10591
smuzaffar merged 1 commit into
cms-sw:IB/CMSSW_20_1_X/masterfrom
Brainz22:toollip-v3-1-0

Conversation

@Brainz22

@Brainz22 Brainz22 commented May 28, 2026

Copy link
Copy Markdown
Contributor

Updated TOoLLiP to version 3.1.0:

  • TOoLLiP continuous development folder is here;
  • CMSSW pull request to integrate this new version lives here. A description on how this model was validated is attached to the pull request description.

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Brainz22 for branch IB/CMSSW_17_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented May 28, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@quinnanm

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d09c2/53558/summary.html
COMMIT: 3042d4f
CMSSW: CMSSW_17_0_X_2026-05-28-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10591/53558/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 15 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 59
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198398
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51057

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d09c2/53563/summary.html
COMMIT: 3042d4f
CMSSW: CMSSW_17_0_X_2026-05-28-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/10591/53563/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4198477
  • DQMHistoTests: Total failures: 16
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4198441
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 197 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@smuzaffar

Copy link
Copy Markdown
Contributor

@Brainz22 @quinnanm , can we merge this before cms-sw/cmssw#51057 or both changes should go in same IB?

@quinnanm

quinnanm commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

hi @smuzaffar, it doesn't really matter either way but theoretically it should come after PR#51057, which updates the inputs for use with this model

@smuzaffar
smuzaffar changed the base branch from IB/CMSSW_17_0_X/master to IB/CMSSW_20_0_X/master June 5, 2026 16:49
@akritkbehera
akritkbehera changed the base branch from IB/CMSSW_20_0_X/master to IB/CMSSW_20_1_X/master June 9, 2026 07:54
@smuzaffar

Copy link
Copy Markdown
Contributor

+externals

@Brainz22 , new TooLLip whcih contains old v1 and new v3 version of TOoLLiP, i think the external should go in first. The existign cmssw code uses v1 and new cmssw PR cms-sw/cmssw#51057 uses v3

[a]

TOoLLiP_tmp_v.so  TOoLLiP_v1.so  TOoLLiP_v2.so  TOoLLiP_v3.so

@smuzaffar
smuzaffar merged commit 3a09371 into cms-sw:IB/CMSSW_20_1_X/master Jun 10, 2026
9 checks passed
@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_20_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)
Notice This PR was tested with additional Pull Request(s), please also merge them if necessary: cms-sw/cmssw#51057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants