Skip to content

Added support for <foreach/for set="var" value="v1,v2"> + cleanup - #89

Merged
smuzaffar merged 1 commit into
SCRAMV3from
loop-support
Jun 12, 2026
Merged

Added support for <foreach/for set="var" value="v1,v2"> + cleanup#89
smuzaffar merged 1 commit into
SCRAMV3from
loop-support

Conversation

@smuzaffar

@smuzaffar smuzaffar commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Cleanup for BuildFile and SimpleDoc parsing. Added support for

<foreach set="i" value="val1,val2">
  <for set="j" value="1,2,1"/>
    <test name="test_${i}_{j}" command="true"/>
  </for>
</foreach>

which should expand to

<test name="test_val1_1" command="true"/>
<test name="test_val1_2" command="true"/>
<test name="test_val2_1" command="true"/>
<test name="test_val2_2" command="true"/>

this can be used for adding tests based on the gpu backends e.g

<foreach set="gpu" value="cuda,rocm">
  <iftool name="pytorch-${gpu}">
    <test name="test-pytorch-${gpu}" command="pytorch-test.py ${gpu}">
     <use name="${gpu}"/>
    </test>
  </iftool>
</foreach>

@cmsbuild

Copy link
Copy Markdown

A new Pull Request was created by @smuzaffar for branch SCRAMV3.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jun 11, 2026

Copy link
Copy Markdown

cms-bot internal usage

@smuzaffar

smuzaffar commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@cmsbuild

Copy link
Copy Markdown

Pull request #89 was updated.

@cmsbuild

Copy link
Copy Markdown

Pull request #89 was updated.

@cmsbuild

Copy link
Copy Markdown

Pull request #89 was updated.

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test using full cmssw

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test using full cmssw for CMSSW_12_4_X

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test using full cmssw for CMSSW_14_0_X

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test using full cmssw for CMSSW_16_1_X

@cmsbuild

Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dae90/53873/summary.html
COMMIT: 256131a
CMSSW: CMSSW_12_4_X_2026-06-07-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/SCRAM/89/53873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild

Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dae90/53870/summary.html
COMMIT: 256131a
CMSSW: CMSSW_20_1_X_2026-06-11-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/SCRAM/89/53870/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dae90/53870/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dae90/53870/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 166 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3267025
  • DQMHistoTests: Total failures: 58
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3266949
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files

@cmsbuild

Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dae90/53874/summary.html
COMMIT: 256131a
CMSSW: CMSSW_14_0_X_2026-06-07-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/SCRAM/89/53874/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@cmsbuild

Copy link
Copy Markdown

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7dae90/53875/summary.html
COMMIT: 256131a
CMSSW: CMSSW_16_1_X_2026-06-11-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/SCRAM/89/53875/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar

Copy link
Copy Markdown
Contributor Author

+externals

@smuzaffar
smuzaffar merged commit 5ac1a6c into SCRAMV3 Jun 12, 2026
26 checks passed
@cmsbuild

Copy link
Copy Markdown

This pull request is fully signed and it will be integrated in one of the next SCRAMV3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants