It could be useful to rename the md5.h for something more specific to avoid name collisions in the future. In Code4hep we ran into an issue where some dependencies pulled in libmd that also provides md5.h with incompatible interface and that md5.h was in the (spack-provided) include paths earlier than the CMS' one.
So not a problem in CMS right now, but future-proofing could be useful. In the same spirit moving the code e.g. in edm_md5 namespace would give further protection against name collisions.
It could be useful to rename the
md5.hfor something more specific to avoid name collisions in the future. In Code4hep we ran into an issue where some dependencies pulled inlibmdthat also providesmd5.hwith incompatible interface and thatmd5.hwas in the (spack-provided) include paths earlier than the CMS' one.So not a problem in CMS right now, but future-proofing could be useful. In the same spirit moving the code e.g. in
edm_md5namespace would give further protection against name collisions.