[BUG] - calling environment_variables endpoint can cause filling up the cloud_controller database

[Benjamintf1]

What happened
each call to /environment_variables causes an audit event to be created by capi. This means the change to automatically use environment variables for the splunk index can cause ddosing the capi database. #404

What you expected to happen:
the splunk nozzle should not cause the creation of tens of thousands of capi audit events

How to reproduce it (as minimally and precisely as possible):
deploy 1.4.2 of the splunk nozzle. view the capi audit db fill up with events

Anything else we need to know?:
just a fyi

Environment:

• Cloud Foundry version
• Go version
• Splunk version: 1.4.2 (post pr 404)
• Others:

[sbylica-splunk]

That's the problem with changes introduced by v3 of cfclient api, mentioned here:
#380

The best way to address this is to set the newly introduced configuration option to USE_ENV_VAR_FOR_SPLUNK_INDEX=false and migrate to labels instead.