feat(favorite/recent): implement new favorite/recent feature (with vue query) by piggggggggy · Pull Request #6136 · cloudforet-io/console

piggggggggy · 2025-08-19T12:52:31Z

Skip Review (optional)

Minor changes that don't affect the functionality (e.g. style, chore, ci, test, docs)
Previously reviewed in feature branch, further review is not mandatory
Self-merge allowed for solo developers or urgent changes

Description (optional)

SSIA

Things to Talk About (optional)

Signed-off-by: samuel.park <samuel.park@megazone.com>

vercel · 2025-08-19T12:52:36Z

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments

Project	Deployment	Preview	Updated (UTC)
console	Ignored	Preview	Aug 22, 2025 7:38am
mfa-saas-qa	Ignored		Aug 22, 2025 7:38am
web-storybook	Ignored		Aug 22, 2025 7:38am

github-actions · 2025-08-19T12:52:43Z

🎉 @skdud4659 has been randomly selected as the reviewer! Please review. 🙏

Copilot

Pull Request Overview

This pull request implements a new favorite/recent feature using Vue Query for better data management and performance. The implementation replaces the existing Vuex store-based favorite and recent functionality with a more modern approach using composables and Vue Query.

Refactors favorite and recent data management from Vuex stores to Vue Query-based composables
Introduces new config-data conversion utilities for better data transformation
Adds comprehensive recent list management with type-specific queries

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
packages/language-pack/*.json	Adds new translation key "ALL_METRIC" and fixes typos in existing translations
apps/web/src/services/workspace-home/components/*.vue	Updates to use new favorite/recent composables instead of store
apps/web/src/services/landing/components/*.vue	Migrates landing page components to new workspace favorite system
apps/web/src/common/modules/favorites/core/*.ts	New favorite management composables using Vue Query
apps/web/src/common/modules/recents/*.ts	New recent list management with CRUD operations
apps/web/src/common/composables/config-data/*.ts	New config data conversion utilities
apps/web/src/query/resource-query/shared/composable/*.ts	Updates resource cache sync functionality

Comments suppressed due to low confidence (2)

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.}

Copilot · 2025-08-19T12:53:23Z

    projects: computed<ProjectReferenceMap>(() => allReferenceGetters.project),
    projectGroups: computed<ProjectGroupReferenceMap>(() => allReferenceGetters.projectGroup),
-    recentList: computed<UserConfigModel[]>(() => workspaceHomePageState.recentList),
+    // recentList: computed<UserConfigModel[]>(() => workspaceHomePageState.recentList),


Remove the commented-out code as it's no longer needed and creates clutter in the codebase.

Suggested change

// recentList: computed<UserConfigModel[]>(() => workspaceHomePageState.recentList),

Copilot · 2025-08-19T12:53:24Z

-        await _updateResourceCache(resourceType, res as Obj, queryClient);
-        return res;
-    };
+    // TODO: annotaion


There's a typo in the TODO comment: 'annotaion' should be 'annotation'.

Suggested change

// TODO: annotaion

// TODO: annotation

Copilot · 2025-08-19T12:53:24Z

+    type: RecentType;
+    workspaceId: string;
+    id: string;
+    options?: {[key:string]: any};


[nitpick] Add a space after the colon in the object type definition: '{[key: string]: any}' for better readability and consistency with TypeScript style conventions.

Suggested change

options?: {[key:string]: any};

options?: { [key: string]: any };

Signed-off-by: samuel.park <samuel.park@megazone.com>

skdud4659

thx!

sulmoJ

LGTM.
I left some comments.

sulmoJ · 2025-08-20T01:38:37Z

+    return useScopedQuery({
+        queryKey: key,
+        queryFn: () => userConfigAPI.list(queryParams.value),
+        enabled: computed(() => {
+            if (enabled === undefined) {
+                return true;
+            }
+            return enabled.value;
+        }),
+    }, ['WORKSPACE', 'USER']);


Question: Why doesn't UserConfig have a 'stale time'?

sulmoJ · 2025-08-20T01:50:13Z

+        if (!dataSourceIds.value?.length) return;
+        loading.value = true;
+        const promises = dataSourceIds.value.map((dataSourceId) => costQuerySetFetcher(dataSourceId));
+        const results = await Promise.all(promises);


Question: Shouldn't you use allSettled?

sulmoJ · 2025-08-20T01:56:16Z

+
+    return {
+        map: computed(() => {
+            const workspaceMap = new Map<string, WorkspaceModel>();


Question: Is it okay for map objects to be placed in a computed?

sulmoJ · 2025-08-20T02:00:51Z

+    workspaceConfigList?: ComputedRef<ConfigData[]>;
+}
+
+export const useConvertReferencedConfigData = ({


Question: I couldn't understand that useConvertReferencedConfigData is a composable.
Could it be a composable that provides the recent and favorite config lists all at once for each resource?

nitpick: The return type is missing.

Signed-off-by: samuel.park <samuel.park@megazone.com>

piggggggggy added 7 commits August 19, 2025 14:26

feat(favorite): create favorite composables

fec1b9f

Signed-off-by: samuel.park <samuel.park@megazone.com>

chore(resource-query-sync): edit wrong queryClient import

a771571

Signed-off-by: samuel.park <samuel.park@megazone.com>

feat(config-data): create new config-data composables

742ce6b

Signed-off-by: samuel.park <samuel.park@megazone.com>

feat(favorite): create new favorite composables

825abed

Signed-off-by: samuel.park <samuel.park@megazone.com>

feat(favorite): apply new favorite module

8190a57

Signed-off-by: samuel.park <samuel.park@megazone.com>

feat(recent): create new recent module

6f187fa

Signed-off-by: samuel.park <samuel.park@megazone.com>

feat(recent): apply new recent module

3951331

Signed-off-by: samuel.park <samuel.park@megazone.com>

piggggggggy requested review from Copilot, skdud4659 and sulmoJ August 19, 2025 12:52

github-actions Bot added the pass/signedoff label Aug 19, 2025

github-actions Bot assigned piggggggggy Aug 19, 2025

Copilot AI reviewed Aug 19, 2025

View reviewed changes

piggggggggy added 2 commits August 19, 2025 21:56

chore: remove unnecessary code

4868681

Signed-off-by: samuel.park <samuel.park@megazone.com>

chore: small fix

5609c9f

Signed-off-by: samuel.park <samuel.park@megazone.com>

skdud4659 approved these changes Aug 20, 2025

View reviewed changes

sulmoJ approved these changes Aug 20, 2025

View reviewed changes

piggggggggy added 4 commits August 22, 2025 13:26

chore: edit dir structure

4535fe3

Signed-off-by: samuel.park <samuel.park@megazone.com>

chore: small fix

6f9c086

Signed-off-by: samuel.park <samuel.park@megazone.com>

chore: small fix

8f70796

Signed-off-by: samuel.park <samuel.park@megazone.com>

chore: edit queryClient name

08df06b

Signed-off-by: samuel.park <samuel.park@megazone.com>

piggggggggy merged commit 300a631 into cloudforet-io:develop Aug 22, 2025
6 checks passed

Navigation Menu

feat(favorite/recent): implement new favorite/recent feature (with vue query) - #6136

feat(favorite/recent): implement new favorite/recent feature (with vue query)#6136
piggggggggy merged 13 commits into
cloudforet-io:developfrom
piggggggggy:query/recent-favorite

piggggggggy commented Aug 19, 2025

Uh oh!

vercel Bot commented Aug 19, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 19, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

Copilot AI Aug 19, 2025

Uh oh!

skdud4659 left a comment

Uh oh!

sulmoJ left a comment

Uh oh!

sulmoJ Aug 20, 2025

Uh oh!

sulmoJ Aug 20, 2025

Uh oh!

sulmoJ Aug 20, 2025

Uh oh!

sulmoJ Aug 20, 2025 •

edited

Loading

Uh oh!

sulmoJ Aug 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	options?: {[key:string]: any};
	options?: { [key: string]: any };

Conversation

piggggggggy commented Aug 19, 2025

Skip Review (optional)

Description (optional)

Things to Talk About (optional)

Uh oh!

vercel Bot commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

skdud4659 left a comment

Choose a reason for hiding this comment

Uh oh!

sulmoJ left a comment

Choose a reason for hiding this comment

Uh oh!

sulmoJ Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

sulmoJ Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

sulmoJ Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

sulmoJ Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sulmoJ Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vercel Bot commented Aug 19, 2025 •

edited

Loading

sulmoJ Aug 20, 2025 •

edited

Loading