[wrangler] Pause automatic skills installation offers - #15296
Conversation
🦋 Changeset detectedLatest commit: 5278581 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
@MattieTK Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
dario-piotrowicz
left a comment
There was a problem hiding this comment.
code-wise I think it would be cleaner to gate the thing instead of removing the code (i.e. adding a const shouldInstall = false or something flag in the code)
from a user perspective I am not sure I agree with the change, but I trust your judgement 👍
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
|
Updated in db80dca: the existing post-command installation flow is retained behind shouldInstall = false, while the update check remains unchanged. The focused skills integration test passes. |
Co-authored-by: Dario Piotrowicz <dario@cloudflare.com>
Automatic skills-installation offers are an experiment that needs changes elsewhere before we can improve it, so this change gates them off for now rather than removing the implementation.
Wrangler still supports --install-skills and continues to offer updates for skills that it previously installed. Re-enabling the automatic offer only requires changing the local gate.