[wrangler] Respect CLOUDFLARE_ENV when loading .env and .dev.vars files - #15282
Open
shubhxho wants to merge 3 commits into
Open
[wrangler] Respect CLOUDFLARE_ENV when loading .env and .dev.vars files#15282shubhxho wants to merge 3 commits into
shubhxho wants to merge 3 commits into
Conversation
workers-devprod
requested review from
a team and
edmundhung
and removed request for
a team
August 20, 2026 14:46
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
🦋 Changeset detectedLatest commit: 7c0839a The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
--env already picked the matching .env.<env> and .dev.vars.<env> files, but CLOUDFLARE_ENV only switched the config environment. Use the same fallback the config loader uses so the two stay in sync.
react-spa headers/redirects has been dying at the default 50s hook timeout on macos-latest, including on unrelated PRs.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
shubhxho
force-pushed
the
fix/cloudflare-env-dotenv-files
branch
from
August 20, 2026 21:55
871b48a to
7c0839a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15068.
CLOUDFLARE_ENValready picks the Wrangler config environment. The.env/.dev.varslookups only looked at--env, so this:activated staging config but still loaded the top-level env files.
Those lookups now use the same fallback the config loader does (
--env, thenCLOUDFLARE_ENV). I leftStartDevWorkerInput.envalone — that's the CLI flag, and writing the env var into it made the redirected-config fixture report a mismatch as coming from--env.CLOUDFLARE_ENVis already documented as an alternative to--env. This just makes the env-file lookup match that.