Upgrade glamour to fix hyperlinks (OSC8) - #281
Conversation
|
This is stacked atop #280 so this either needs to be split into a separate PR atop |
|
This is part of a stack but not showing here because stacks aren't enabled for this repo it seems: I can split these later if needs be, but stacks at least make it easier to |
|
I would prefer this dependency bump on its own and not stacked with the unrelated change please. If you have the time; proof that it doesn't break tests in cli/cli would also be an asset to decrease the review burden. If it does break tests, some investigation into why is in order as well. I don't understand the "replacement module" comment, sorry. If that's something you meant for us to action, can you expand on that? |
@BagToad if you're open to taking it, I can unstack them. I mainly did that so I could simply build against the head of the stack against my fork. Less for the stack and more for the natural I'm making a similar change to the cli right now for cli/cli#3718. There were a few expected But how would this change impact the cli directly? I see you are using |
|
The lint issue is that |
|
Since I can't rerun the failed test I simply amended the commit and did a force push. |
Fixes #188