fix: write .claude.json to ~/.claude/ instead of homedir root

[p2p3p]

将 .claude.json 写入路径从 homedir() 根目录改为 getClaudeConfigHomeDir() 对应的 ~/.claude/ 目录。

Summary by CodeRabbit

• Bug Fixes
  • Improved configuration file discovery by honoring the configured settings directory when no explicit override is provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

getGlobalClaudeFile now uses getClaudeConfigHomeDir() as its fallback directory. The CLAUDE_CONFIG_DIR override and filename construction remain unchanged.

Changes

Configuration path resolution

Layer / File(s)	Summary
Global file fallback src/utils/env.ts	getGlobalClaudeFile uses getClaudeConfigHomeDir() when CLAUDE_CONFIG_DIR is not set.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related issues

• b #1334 — Describes the same getGlobalClaudeFile() path-resolution bug.

Possibly related PRs

• claude-code-best/claude-code#1312 — Updates related path resolution to use getClaudeConfigHomeDir().

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes moving .claude.json writes from the home directory to the ~/.claude/ configuration directory.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/utils/env.ts`:
- Around line 25-28: Update the directory argument in the configuration path
construction to use getClaudeConfigHomeDir() directly, removing the
process.env.CLAUDE_CONFIG_DIR || fallback expression. Preserve joining the
resolved directory with filename so empty environment values follow the helper’s
home-directory behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3dc5cd31-9f23-47fb-bdbf-468caedbb66a

📥 Commits

Reviewing files that changed from the base of the PR and between 2ccc216 and c72b7f5.

📒 Files selected for processing (1)

• src/utils/env.ts

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Use getClaudeConfigHomeDir() as the sole directory resolver.

When CLAUDE_CONFIG_DIR is set to an empty string, getClaudeConfigHomeDir() returns "" because it uses ??. The || expression therefore still yields "", and join("", filename) resolves to the current working directory instead of ~/.claude/. This can split or misplace the global configuration. Use the helper directly.

Proposed fix

   return join(
-    process.env.CLAUDE_CONFIG_DIR || getClaudeConfigHomeDir(),
+    getClaudeConfigHomeDir(),
     filename,
   )

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/utils/env.ts` around lines 25 - 28, Update the directory argument in the
configuration path construction to use getClaudeConfigHomeDir() directly,
removing the process.env.CLAUDE_CONFIG_DIR || fallback expression. Preserve
joining the resolved directory with filename so empty environment values follow
the helper’s home-directory behavior.