Feature/message sending by B00tLoad · Pull Request #2 · cis-oss/pushover

B00tLoad · 2025-08-30T19:38:40Z

No description provided.

As it seems I did not fix the eslint not throwing, so I need to temporarily put the call to cmd back in until further investigation Refs: 5304933 Format: text/plain Milestone: none BREAKING-CHANGE: calling the windows command line cmd will probably make the pre-commit hook not work on non-windows systems

Previous glob was `**/*` Format: text/markdown Milestone: none

Message sending is not yet feature complete Missing: - attachments - priority 2 -> retry & expire Format: text/markdown Milestone: minor

- Build files now include sourcemaps and declarations - No longer compiles non-ts files - package.json includes build:watch script Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Added eslint-plugin-only-warn to suppress errors Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

including zod schema validation Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Milestone: none Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Validates user and if specified device Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

removes default user, changes recipient to optionally include device Also fixes url_title replacing message title Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

This is needed by TypeDoc Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Refs: 8d711af

Copilot

Pull Request Overview

This PR introduces a complete message sending feature for the Pushover notification service, replacing the previous type-only implementation with a fully functional API client. The main changes include implementing the core Pushover class with HTTP request handling, comprehensive message validation using Zod schemas, and support for all Pushover API features including emergency notifications, receipt management, and user validation.

Key changes:

Complete rewrite of the main entry point to export a functional Pushover class
Implementation of comprehensive Pushover API client with full feature support
Addition of basic test coverage for the exported functionality

Reviewed Changes

Copilot reviewed 6 out of 9 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/index.ts	Replaces type definitions with imports from new Pushover class implementation
src/Pushover.ts	Implements complete Pushover API client with validation, sending, and management features
tests/index.spec.ts	Adds basic test coverage for exported Pushover class
package.json	Updates build configuration and adds testing dependencies
eslint.config.mjs	Adds eslint-plugin-only-warn for development
.husky/pre-commit	Updates pre-commit hook to use pnpm

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-30T20:15:59Z

+ *   priority: 2,
+ *   emergencyOpts: {
+ *     retry: 60, // Retry every 60 seconds
+ *     expire: 3600 // Expire after 1 hour


Missing comma after the array in the JSDoc example code block.

jateute

lgtm

jateute

lgtm

B00tLoad added 22 commits March 13, 2025 02:30

build(pre-commit): fixing eslint for windows

7db7cad

build(tsconfig): specify include globs to /src/**/*

09645c3

Previous glob was `**/*` Format: text/markdown Milestone: none

feat: sends message

ac239fd

Message sending is not yet feature complete Missing: - attachments - priority 2 -> retry & expire Format: text/markdown Milestone: minor

fix: log request error to console

f48bd35

feat: Adds typechecking via zod for message

d520d52

build(tsconfig): Updates config, adds build:watch script

e5a3e04

- Build files now include sourcemaps and declarations - No longer compiles non-ts files - package.json includes build:watch script Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

ci(pre-commit): Pre-commit hook now should no longer block commits

a72a2c3

Added eslint-plugin-only-warn to suppress errors Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

feat: sending messages is now feature complete

2106734

including zod schema validation Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

build(tests): Adds jest to run tests

6a8cf52

Milestone: none Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

feat: Adds user validation via api

52b11ee

Validates user and if specified device Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

chore(package.json): add types

65524da

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

fix: removes module.exports

2007e90

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

refactor: recipient handling

b09b0bc

removes default user, changes recipient to optionally include device Also fixes url_title replacing message title Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

build(package.json): adds tsx to test functionality using ts files

6482944

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

feat: Add receipt checking and retry cancellation

f9385c9

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

refactor: Split out zod input and output type

5cfbc8d

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

docs: Documented methods

15beebf

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

feat: exports types

6d2743e

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

build(tsconfig.json): sets strictNullChecks to true

609e6dc

This is needed by TypeDoc Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

chore(package.json): added packageManager field

37fdebd

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

ci(pre-commit): fix hook t user pnpm instead of npm

143796f

Signed-off-by: Alix von Schirp <github@avonschirp.bootmedia.de>

B00tLoad requested review from Copilot and jateute August 30, 2025 19:38

B00tLoad self-assigned this Aug 30, 2025

B00tLoad added the enhancement New feature or request label Aug 30, 2025

This comment was marked as outdated.

Sign in to view

B00tLoad and others added 3 commits August 30, 2025 21:43

style: add missing brackets in template

8d711af

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix(user-validation): remove nullish coalescing operator

9b88ae8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: fix syntax errors introduced by copilot in previous commit

5e46450

Refs: 8d711af

B00tLoad requested a review from Copilot August 30, 2025 20:14

This comment was marked as outdated.

Sign in to view

B00tLoad requested a review from Copilot August 30, 2025 20:15

Copilot AI reviewed Aug 30, 2025

View reviewed changes

B00tLoad requested review from jateute and removed request for jateute August 30, 2025 20:18

jateute approved these changes Aug 30, 2025

View reviewed changes

B00tLoad added 2 commits August 30, 2025 22:26

docs(Message): added missing comma

4f6015a

fix(send): added missing return

8566327

B00tLoad requested a review from jateute August 30, 2025 20:29

docs: reformat code examples to follow prettier styling

d66c54d

jateute approved these changes Aug 31, 2025

View reviewed changes

B00tLoad merged commit f4f6046 into develop Aug 31, 2025
2 checks passed

B00tLoad deleted the feature/message-sending branch August 31, 2025 11:59

Navigation Menu

Uh oh!

Feature/message sending - #2

Feature/message sending#2
B00tLoad merged 28 commits into
developfrom
feature/message-sending

B00tLoad commented Aug 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Aug 30, 2025

Uh oh!

jateute left a comment

Uh oh!

jateute left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

B00tLoad commented Aug 30, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Aug 30, 2025

Choose a reason for hiding this comment

Uh oh!

jateute left a comment

Choose a reason for hiding this comment

Uh oh!

jateute left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants