Skip to content

fix: select the fast-transfer fee tier explicitly instead of by array order #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bars26 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: select the fast-transfer fee tier explicitly instead of by array order #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/hooks/use-cross-chain-transfer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ interface AttestationResponse {
}

interface FastTransferFeeResponse {
finalityThreshold: number;
minimumFee: number | string;
}

Expand Down Expand Up @@ -1024,7 +1025,13 @@ export function useCrossChainTransfer() {
}

const feePayload = (await response.json()) as FastTransferFeeResponse[];
const feeEntry = feePayload[0];
// Select the fee for the tier we actually burn at (fast transfers pass
// minFinalityThreshold = FAST_FINALITY_THRESHOLD) rather than trusting the
// order of the response array.
const feeEntry =
feePayload.find(
(entry) => entry.finalityThreshold <= FAST_FINALITY_THRESHOLD,
) ?? feePayload[0];
if (!feeEntry) {
throw new Error("No fee returned for this route");
}
Expand Down