Conversation
Author
|
@hjchen-circle, #160 correctly made the old RPC rewrite in #149 unnecessary. While checking the current Arc flow, I found that Arc is now the default source with Fast selected even though it is Standard-only as a source in Circle's support table. This PR updates that current behavior and keeps the check in both the UI and transfer path. I verified the Arc/Arbitrum/Arc selection flow in a browser as well as lint and production build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #160, the app opens with Arc Testnet as the source and Fast Transfer selected. Circle currently lists Arc as a Standard Transfer source only, so the default UI promises a faster route that is not available for that source. The same mismatch applies to several other supported source chains.
This change:
1000instead of assuming the first API item is the Fast feeFast-capable sources follow Circle's supported chains table:
https://developers.circle.com/cctp/concepts/supported-chains-and-domains
Checked with:
npm run lint(passes; existinggetBalancehook warning remains)npm run build