[BUG](worker): Revert the async fn window widening from #7621 - #7684
Open
dbeglord wants to merge 1 commit into
Open
[BUG](worker): Revert the async fn window widening from #7621#7684dbeglord wants to merge 1 commit into
dbeglord wants to merge 1 commit into
Conversation
The fn-consumer reads a window of log records between committed compaction boundaries. Restore it to stopping at the nearest committed boundary rather than widening to the furthest one that still fits max_compaction_size. Widening makes job length swing up to the size cap instead of tracking a single compaction window, and max_compaction_size is the knob meant to tune that. The synthesis backend also splits large requests to stay under its own request-size limits, so a wider window is split apart again downstream. Scope is the boundary-selection code and the tests asserting it. #7621 also carried unrelated cleanups -- a chunks_exact(N) -> as_chunks::<N>() migration across the index and types crates, and two drain(..).collect() -> std::mem::take call sites -- which stay. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fn-consumer reads a window of log records between committed compaction boundaries. This restores it to stopping at the nearest committed boundary, rather than widening to the furthest boundary that still fits
max_compaction_size.Why
Widening makes job length swing up to the size cap instead of tracking a single compaction window, and
max_compaction_sizeis the knob meant to tune that. The synthesis backend also splits large requests to stay under its own request-size limits, so a wider window gets split apart again downstream. This matches the decision made when #7621 was backed out of production on Aug 21.Scope
Two files: the boundary-selection code and the tests that assert it.
#7621 also carried cleanups unrelated to window selection — a
chunks_exact(N)→as_chunks::<N>()migration across the index and types crates, and twodrain(..).collect()→std::mem::takecall sites. Those stay. The diff here is the exact inverse of #7621 for the two files it touches, and nothing else has modified them since it merged.Production context
This behavior is already absent from production. It was hotfixed onto
release/2026-08-18and then reverted there, but the matching revert never landed onmain— so it is present inrelease/2026-08-31, and promoting that branch would reintroduce it.Once this merges, a cherry-pick onto
release/2026-08-31(via theapply-hotfixworkflow) closes the second path, ahead of the production promotion.Validation
cargo check -p worker --testspasses.🤖 Generated with Claude Code