Skip to content

[BLD](ci): Pin minikube to 1.38.1 in tilt-setup-prebuild - #7676

Merged
davedash merged 1 commit into
mainfrom
dave/pin-minikube-1-38-1
Sep 2, 2026
Merged

[BLD](ci): Pin minikube to 1.38.1 in tilt-setup-prebuild#7676
davedash merged 1 commit into
mainfrom
dave/pin-minikube-1-38-1

Conversation

@davedash

@davedash davedash commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Description

tilt-setup-prebuild uses medyagh/setup-minikube@latest with no minikube-version, so the minikube version resolves at run time. minikube 1.39.0 (picked up starting 2026-09-02) fails to start the none driver on GitHub runners: it selects the containerd runtime and setup dies with

X Exiting due to RUNTIME_ENABLE: Failed to start container runtime: Temporary Error: sudo /usr/local/bin/crictl version: exit status 1
validate CRI v1 runtime API for endpoint "unix:///run/containerd/containerd.sock": rpc error: code = Unimplemented desc = unknown service runtime.v1.RuntimeService

This broke every hosted-chroma tilt CI job today (this repo's own tilt jobs consume the same action). The last job to pass used 1.38.1 (2026-09-01); the first to fail used 1.39.0 — reruns reproduce it deterministically.

Change

Pin minikube-version: 1.38.1 (last known good). We can unpin or bump once minikube's none-driver regression is fixed upstream.

Validation

  • Failing hosted runs: js, JS (E2E) — both die in minikube setup before any test runs.
  • Passing 1.38.1 run for contrast: JS (E2E) on hosted #8324.
  • This PR's own CI exercises the pinned action.

🤖 Generated with Claude Code

setup-minikube@latest resolves the minikube version at run time; 1.39.0
(released 2026-09-02) fails to start the none driver on GitHub runners -
it selects the containerd runtime and crictl dies with 'unknown service
runtime.v1.RuntimeService' - which broke every hosted-chroma tilt CI
job today. Pin the last known-good 1.38.1.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@davedash
davedash enabled auto-merge (squash) September 2, 2026 23:36
@davedash
davedash merged commit f60fe42 into main Sep 2, 2026
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant