Skip to content

[ENH](fn-consumer): Show collection IDs in list-in-progress-jobs - #7675

Merged
tanujnay112 merged 1 commit into
mainfrom
codex/fn-consumer-list-collection-ids
Sep 3, 2026
Merged

[ENH](fn-consumer): Show collection IDs in list-in-progress-jobs#7675
tanujnay112 merged 1 commit into
mainfrom
codex/fn-consumer-list-collection-ids

Conversation

@tanujnay112

@tanujnay112 tanujnay112 commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Expose the input collection UUIDs for each active fn-consumer job.

The fn-consumer now retains the collection IDs from each dispatched batch and returns them through the existing ListInProgressJobs RPC as a backward-compatible repeated field.

Testing

  • cargo fmt --all --check
  • git diff --check
  • focused worker test build started locally; full validation is delegated to CI

Compatibility

The new protobuf field uses tag 3, so existing clients remain wire-compatible. No migration or deployment configuration changes are required.

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@tanujnay112
tanujnay112 marked this pull request as ready for review September 2, 2026 22:14

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T22:16:46.740588Z bee9bb3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tanujnay112 tanujnay112 changed the title [ENH](fn-consumer): Show collection IDs [ENH](fn-consumer): Show collection IDs in list-in-progress-jobs Sep 2, 2026

@dbeglord dbeglord left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending tests

@tanujnay112
tanujnay112 enabled auto-merge (squash) September 3, 2026 08:14
@tanujnay112
tanujnay112 force-pushed the codex/fn-consumer-list-collection-ids branch from bee9bb3 to e04a4f3 Compare September 3, 2026 16:07
@tanujnay112
tanujnay112 merged commit 34f8e76 into main Sep 3, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants