[TST] Gate property test compaction waits behind a toggle - #7674
Closed
rescrv wants to merge 1 commit into
Closed
Conversation
Property filtering tests unconditionally waited for random compactions in cluster mode, which made runs slow and flaky. Introduce hypothesis_driven_compaction_waits_enabled() in conftest, driven by the CHROMA_HYPOTHESIS_COMPACTION_WAITS env var (auto/always/never). In auto mode, waits only run under the "slow" preset. Refactor the repeated @settings decorators in test_filtering.py into a shared filtering_settings() helper that lowers max_examples in cluster mode and optionally suppresses the filter_too_much health check. Replace the direct "not NOT_CLUSTER_ONLY" compaction-wait guards with the new RUN_RANDOM_COMPACTION_WAITS flag. Add test_hypothesis_settings.py covering the preset/mode matrix, the outside-cluster short circuit, and invalid-mode rejection. Also tighten type annotations across the filtering tests. Co-authored-by: AI
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Property filtering tests unconditionally waited for random compactions
in cluster mode, which made runs slow and flaky. Introduce
hypothesis_driven_compaction_waits_enabled() in conftest, driven by the
CHROMA_HYPOTHESIS_COMPACTION_WAITS env var (auto/always/never). In auto
mode, waits only run under the "slow" preset.
Refactor the repeated @settings decorators in test_filtering.py into a
shared filtering_settings() helper that lowers max_examples in cluster
mode and optionally suppresses the filter_too_much health check. Replace
the direct "not NOT_CLUSTER_ONLY" compaction-wait guards with the new
RUN_RANDOM_COMPACTION_WAITS flag.
Add test_hypothesis_settings.py covering the preset/mode matrix,
the outside-cluster short circuit, and invalid-mode rejection. Also
tighten type annotations across the filtering tests.
Test plan
CI only
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A
Co-authored-by: AI