[TST] Make work queue integration test order-agnostic - #7673
Merged
Conversation
The live fn-consumer can defer an item while this test runs, moving it to the back of the queue and breaking the previous FIFO-order assertion. Verify each retrieved item by matching its fn_id to the expected completion offset instead of relying on push order. Rename the test to test_k8s_integration_work_queue_enqueue_and_filtering to reflect that it checks enqueue and filtering rather than FIFO ordering, which remains covered by the QueueState unit tests. Co-authored-by: AI
Contributor
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
tanujnay112
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The live fn-consumer can defer an item while this test runs, moving
it to the back of the queue and breaking the previous FIFO-order
assertion. Verify each retrieved item by matching its fn_id to the
expected completion offset instead of relying on push order.
Rename the test to test_k8s_integration_work_queue_enqueue_and_filtering
to reflect that it checks enqueue and filtering rather than FIFO
ordering, which remains covered by the QueueState unit tests.
Test plan
CI
Migration plan
N/A
Observability plan
N/A
Documentation Changes
N/A
Co-authored-by: AI