-
Notifications
You must be signed in to change notification settings - Fork 2.5k
[ENH](fn-consumer): List in-progress jobs #7668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package chroma; | ||
|
|
||
| message ListFnConsumerInProgressJobsRequest {} | ||
|
|
||
| message FnConsumerInProgressJobInfo { | ||
| string fn_id = 1; | ||
| int64 expires_at_epoch_secs = 2; | ||
| } | ||
|
|
||
| message ListFnConsumerInProgressJobsResponse { | ||
| repeated FnConsumerInProgressJobInfo jobs = 1; | ||
| } | ||
|
|
||
| service FnConsumer { | ||
| rpc ListInProgressJobs(ListFnConsumerInProgressJobsRequest) returns (ListFnConsumerInProgressJobsResponse) {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| use async_trait::async_trait; | ||
| use chroma_system::ComponentHandle; | ||
| use chroma_types::chroma_proto::{ | ||
| fn_consumer_server::{FnConsumer, FnConsumerServer}, | ||
| FnConsumerInProgressJobInfo, ListFnConsumerInProgressJobsRequest, | ||
| ListFnConsumerInProgressJobsResponse, | ||
| }; | ||
| use tonic::{Request, Response, Status}; | ||
|
|
||
| use super::fn_consumer_manager::{FnConsumerManager, ListInProgressJobsMessage}; | ||
|
|
||
| pub struct FnConsumerGrpcServer { | ||
| manager: ComponentHandle<FnConsumerManager>, | ||
| } | ||
|
|
||
| impl FnConsumerGrpcServer { | ||
| pub fn new(manager: ComponentHandle<FnConsumerManager>) -> Self { | ||
| Self { manager } | ||
| } | ||
|
|
||
| pub fn into_service(self) -> FnConsumerServer<Self> { | ||
| FnConsumerServer::new(self) | ||
| } | ||
| } | ||
|
|
||
| #[async_trait] | ||
| impl FnConsumer for FnConsumerGrpcServer { | ||
| async fn list_in_progress_jobs( | ||
| &self, | ||
| _request: Request<ListFnConsumerInProgressJobsRequest>, | ||
| ) -> Result<Response<ListFnConsumerInProgressJobsResponse>, Status> { | ||
| let (response_tx, response_rx) = tokio::sync::oneshot::channel(); | ||
| self.manager | ||
| .receiver() | ||
| .send(ListInProgressJobsMessage { response_tx }, None) | ||
| .await | ||
| .map_err(|error| Status::internal(error.to_string()))?; | ||
|
|
||
| let jobs = response_rx | ||
| .await | ||
| .map_err(|error| Status::internal(format!("Failed to receive response: {error}")))? | ||
| .into_iter() | ||
| .map(|entry| FnConsumerInProgressJobInfo { | ||
| fn_id: entry.fn_id.to_string(), | ||
| expires_at_epoch_secs: entry.expires_at_epoch_secs, | ||
| }) | ||
| .collect(); | ||
|
|
||
| Ok(Response::new(ListFnConsumerInProgressJobsResponse { jobs })) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| pub mod config; | ||
| pub mod fn_consumer_manager; | ||
| mod grpc; | ||
| pub mod server; | ||
|
|
||
| pub use server::fn_consumer_service_entrypoint; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.