Skip to content

[BUG](tracing): Ignore blank OTEL endpoint - #7665

Open
anishfyi wants to merge 1 commit into
chroma-core:mainfrom
anishfyi:fix-4609-empty-otel-endpoint
Open

[BUG](tracing): Ignore blank OTEL endpoint#7665
anishfyi wants to merge 1 commit into
chroma-core:mainfrom
anishfyi:fix-4609-empty-otel-endpoint

Conversation

@anishfyi

Copy link
Copy Markdown

Description

Treat empty and whitespace-only OpenTelemetry endpoints as disabled instead of passing them to the OTLP exporter and panicking on an invalid URI.

The tracing layer now returns an identity layer for blank endpoints, so stdout tracing can continue without attempting OTLP exporter initialization.

Closes #4609

Test plan

  • cargo test -p chroma-tracing
  • cargo test -p chroma-tracing --doc
  • cargo clippy -p chroma-tracing --tests -- -D warnings
  • cargo fmt --all -- --check

Treat an empty or whitespace-only endpoint as disabled so blank environment variables do not cause exporter initialization to panic.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Open Telemetry is configured when environment variables are blank

1 participant