Skip to content

[TST] Enable quantized spann in CI - #6750

Open
Sicheng-Pan wants to merge 7 commits into
mainfrom
03-26-_tst_enable_quantized_spann_in_ci
Open

[TST] Enable quantized spann in CI#6750
Sicheng-Pan wants to merge 7 commits into
mainfrom
03-26-_tst_enable_quantized_spann_in_ci

Conversation

@Sicheng-Pan

@Sicheng-Pan Sicheng-Pan commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Enable quantized spann in CI
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

Copy link
Copy Markdown

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan
Sicheng-Pan marked this pull request as ready for review March 26, 2026 22:01
@propel-code-bot

propel-code-bot Bot commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Enable quantized SPANN in CI with test tolerance and resource tuning updates

This PR primarily enables quantized SPANN behavior in CI distributed environments and stabilizes related tests. It updates distributed frontend sample configs to enable quantization for all tenants via tenants_with_quantization_enabled: ["*"], adjusts Kubernetes dev resource allocations (notably queryService, compactionService, and rustLogService CPU), and increases cluster CI runner size in .github/workflows/_python-tests.yml.

To reduce quantization-related flakiness, the PR updates property and schema tests to tolerate server-assigned/tuned SPANN values and quantized distance error bounds. In chromadb/test/property/invariants.py, distance validation now detects active quantization from serialized_schema and applies an absolute tolerance derived from vector norms and dimensionality. Additional test refinements include dimension range constraints in property strategies and acceptance of SegmentType::QuantizedSpann in Rust integration assertions.

This summary was automatically generated by @propel-code-bot

propel-code-bot[bot]

This comment was marked as outdated.

@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch 3 times, most recently from 7baab00 to 6be8e13 Compare March 27, 2026 03:20
propel-code-bot[bot]

This comment was marked as outdated.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from fb6099f to 6560603 Compare March 27, 2026 17:39
propel-code-bot[bot]

This comment was marked as outdated.

@blacksmith-sh

This comment has been minimized.

propel-code-bot[bot]

This comment was marked as outdated.

@blacksmith-sh

This comment has been minimized.

@propel-code-bot propel-code-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues were identified; changes appear consistent with enabling quantized SPANN in CI and reducing test flakiness.

Status: No Issues Found | Risk: Low

Review Details

📁 10 files reviewed | 💬 0 comments

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from d5de183 to faba758 Compare April 8, 2026 17:54
@blacksmith-sh

This comment has been minimized.

@sanketkedia

sanketkedia commented Apr 17, 2026

Copy link
Copy Markdown
Contributor

Just confirming my understanding of the change - you have not yet enabled quantization in CI just made sure that if and when we do, the tests would pass successfully? Is that correct? And you would enable it in CI in a follow up PR?

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from faba758 to c3ab46f Compare April 17, 2026 21:14
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch 2 times, most recently from be05346 to f04737e Compare April 20, 2026 18:06
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch 2 times, most recently from 031709e to 54caa34 Compare April 20, 2026 21:57
@github-actions

Copy link
Copy Markdown

⚠️ The Helm chart was updated without a version bump. Your changes will only be published if the version field in k8s/distributed-chroma/Chart.yaml is updated.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from 54caa34 to d436913 Compare April 20, 2026 23:00
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from 68e8ea1 to 13289d8 Compare April 21, 2026 01:56
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch 2 times, most recently from 07808b5 to e852c9a Compare April 22, 2026 19:58
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from e852c9a to 37e5527 Compare April 23, 2026 18:23
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from 37e5527 to 639e874 Compare April 27, 2026 18:17
@blacksmith-sh

This comment has been minimized.

@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from 639e874 to 24bd67d Compare April 28, 2026 00:08
@Sicheng-Pan
Sicheng-Pan force-pushed the 03-26-_tst_enable_quantized_spann_in_ci branch from 24bd67d to 394f98e Compare April 28, 2026 20:58
@blacksmith-sh

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants