Repository navigation
Quote the unit test coverage exclude so Windows CI passes - #53
Merged
charles2ke merged 2 commits intoOct 2, 2026
Merged
charles2ke merged 2 commits into
charles2ke merged 2 commits into
Conversation
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused change correctly resolves Windows argument handling without altering test behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Updates the unit-test command for cross-platform coverage exclusion.
Changes:
- Uses escaped double quotes so Windows and POSIX shells correctly exclude test files from coverage.
| File | Description |
|---|---|
package.json |
Fixes cross-platform quoting in test:unit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Playwright screenshots for desktop, Android, and iOS are available in artifact #11195465257. |
charles2ke
merged commit Oct 2, 2026
8438b7c
into
copilot/create-windows-desktop-app-pipeline
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Build Windows desktop appcheck failed at thenpm run test:unitstep.cmd.exedoes not strip single quotes, so Node received the literal pattern'test/**', the exclude never matched, and the test files themselves were measured against the enforced 100% coverage thresholds (99.72% branch / 95.97% function → exit 1).Changes
package.json: switch the--test-coverage-excludeargument intest:unitfrom single to escaped double quotes, which bothcmd.exeand POSIX shells strip.Notes
Pull request qualityfailure on the same commit could not be reproduced — lint, unit, build, and Playwright e2e all pass on this branch. Worth a re-run to confirm whether it was transient.Update README after mergeis a post-merge, push-permission workflow unrelated to this change.