Skip to content

Quote the unit test coverage exclude so Windows CI passes - #53

Merged
charles2ke merged 2 commits into
copilot/create-windows-desktop-app-pipelinefrom
copilot/update-trading-strategy
Oct 2, 2026
Merged

charles2ke merged 2 commits into
copilot/create-windows-desktop-app-pipelinefrom
copilot/update-trading-strategy

Conversation

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

The Build Windows desktop app check failed at the npm run test:unit step. cmd.exe does not strip single quotes, so Node received the literal pattern 'test/**', the exclude never matched, and the test files themselves were measured against the enforced 100% coverage thresholds (99.72% branch / 95.97% function → exit 1).

Changes

  • package.json: switch the --test-coverage-exclude argument in test:unit from single to escaped double quotes, which both cmd.exe and POSIX shells strip.
-"test:unit": "node --test ... --test-coverage-exclude='test/**' ..."
+"test:unit": "node --test ... --test-coverage-exclude=\"test/**\" ..."

Notes

  • Job logs for the referenced run have expired, so the diagnosis came from reproducing the Windows argument handling locally.
  • The Pull request quality failure on the same commit could not be reproduced — lint, unit, build, and Playwright e2e all pass on this branch. Worth a re-run to confirm whether it was transient.
  • Update README after merge is a post-merge, push-permission workflow unrelated to this change.

Copilot AI and others added 2 commits September 28, 2026 08:43
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused change correctly resolves Windows argument handling without altering test behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Updates the unit-test command for cross-platform coverage exclusion.

Changes:

  • Uses escaped double quotes so Windows and POSIX shells correctly exclude test files from coverage.
File Description
package.json Fixes cross-platform quoting in test:unit.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Playwright screenshots for desktop, Android, and iOS are available in artifact #11195465257.

@charles2ke
charles2ke merged commit 8438b7c into copilot/create-windows-desktop-app-pipeline Oct 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants