Skip to content

Fix audit log table hiding its Action column on mobile - #52

Merged
charles2ke merged 2 commits into
copilot/add-audit-data-view-pagefrom
copilot/charles2ke-fixed-merge-conflict
Oct 6, 2026
Merged

charles2ke merged 2 commits into
copilot/add-audit-data-view-pagefrom
copilot/charles2ke-fixed-merge-conflict

Conversation

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

The audit log e2e test failed on the android and ios Playwright projects: the portfolio.write cell resolved but was hidden. Cause is a global responsive rule that hides the second column of every table below 760px — added for the markets table's "Exchange" column, but it also removes the audit log's "Action" column, the most meaningful field on that page.

Changes

  • src/styles.css: scoped the column-hiding rule to non-audit panels, and hide the audit table's "Actor" column (4th) on small screens instead.
/* before */
th:nth-child(2), td:nth-child(2) { display: none; }

/* after */
.panel:not(.audit-panel) th:nth-child(2), .panel:not(.audit-panel) td:nth-child(2) { display: none; }
.audit-panel th:nth-child(4), .audit-panel td:nth-child(4) { display: none; }
  • e2e/screenshots/: mobile screenshots regenerated by the test run, reflecting the visible Action column.

Markets table behaviour on mobile is unchanged. The audit "Actor" value is a pseudonymized id and is still present in the CSV/JSON downloads.

Copilot AI and others added 2 commits September 28, 2026 08:45
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused CSS change preserves existing portfolio behavior and correctly exposes audit actions on mobile.

Review effort: Balanced
Findings: None

What changed in this PR

Scopes responsive table hiding so mobile audit logs retain the Action column while hiding Actor instead.

Changes:

  • Excludes audit tables from the global second-column hiding rule.
  • Hides the audit Actor column on small screens.
  • Updates the mobile audit snapshot.
File Description
src/​styles.css Adds audit-specific responsive column visibility.
e2e/​screenshots/​audit-log-mobile.png Updates the mobile visual reference.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Playwright screenshots for desktop, Android, and iOS are available in artifact #11194880702.

@charles2ke
charles2ke merged commit 5c280c5 into copilot/add-audit-data-view-page Oct 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants