Repository navigation
Fix audit log table hiding its Action column on mobile - #52
Merged
charles2ke merged 2 commits intoOct 6, 2026
Merged
charles2ke merged 2 commits into
charles2ke merged 2 commits into
Conversation
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>
Co-authored-by: charles2ke <6725706+charles2ke@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused CSS change preserves existing portfolio behavior and correctly exposes audit actions on mobile.
Review effort: Balanced
Findings: None
What changed in this PR
Scopes responsive table hiding so mobile audit logs retain the Action column while hiding Actor instead.
Changes:
- Excludes audit tables from the global second-column hiding rule.
- Hides the audit Actor column on small screens.
- Updates the mobile audit snapshot.
| File | Description |
|---|---|
src/styles.css |
Adds audit-specific responsive column visibility. |
e2e/screenshots/audit-log-mobile.png |
Updates the mobile visual reference. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Playwright screenshots for desktop, Android, and iOS are available in artifact #11194880702. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit log e2e test failed on the
androidandiosPlaywright projects: theportfolio.writecell resolved but washidden. Cause is a global responsive rule that hides the second column of every table below 760px — added for the markets table's "Exchange" column, but it also removes the audit log's "Action" column, the most meaningful field on that page.Changes
src/styles.css: scoped the column-hiding rule to non-audit panels, and hide the audit table's "Actor" column (4th) on small screens instead.e2e/screenshots/: mobile screenshots regenerated by the test run, reflecting the visible Action column.Markets table behaviour on mobile is unchanged. The audit "Actor" value is a pseudonymized id and is still present in the CSV/JSON downloads.