Repository navigation
feat: allow users to have an associated barcode - #151
Merged
Merged
Conversation
YtvwlD
requested changes
Dec 29, 2025
YtvwlD
left a comment
YtvwlD
left a comment
Member
There was a problem hiding this comment.
All in all this look pretty good!
Just two things:
- A user can only have a single barcode. Is this correct?
- The
null: truein the migrations breaks on sqlite. Can we remove this?
Contributor
Author
yes, that was the simplest to implement. it can change that to multiple tho if you think that'd be practical
do they? |
Member
|
This really depends on the use-case (which I don't really know). I'm fine with a single barcode per account; we could even change this later. This is the error I got when migrating an existing dev setup: I can reproduce this by switching to |
Contributor
Author
the main use case this one has is to strap an ibutton/nfc reader to the chaosdorf mete terminal and do faster user selection with that
hmm, weird. it removed the |
Contributor
Author
|
beep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to have an optional personal barcode so that they can quickly open their page using a [library card, iButton, nfc implant]. lucy hasn't done anything with rails before so it's sorry if this code is bad.