Repository navigation
eoswrapper: return the EOS error instead of panicking - #85
Merged
Merged
Conversation
New asserted the FS type before checking the error, so an EOS that could not be set up at startup (e.g. its gRPC endpoint refusing connections) crashed revad instead of failing the storage provider.
gmgigi96
force-pushed
the
eoswrapper-check-err
branch
from
October 8, 2026 15:35
01ddf0f to
94ecb2d
Compare
diocas
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the error from NewEOSFS before asserting its type, so an EOS that cannot be set up at startup fails the storage provider instead of crashing revad.