Repository navigation
Conversation
Co-authored-by: marco.massarelli <marco.massarelli@gmail.com>
|
Cursor Agent can help with this pull request. Just |
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if (fileInputRef.current) { | ||
| fileInputRef.current.value = ''; | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Conflict dialog leaves loading state active UI bug
When processFootprints encounters a conflict and shows the conflict dialog, it returns early without calling generateNow(). However, the finally block in handleLocalFile only resets isLoading but not isGenerating. This leaves isGenerating=true while waiting for user input on the conflict dialog, causing the UI to incorrectly display a loading/generating state. The finally block should also call setIsGenerating(false), or there should be a check to reset isGenerating when a conflict dialog appears (similar to how handleConflictCancel resets both states).
Co-authored-by: marco.massarelli <marco.massarelli@gmail.com>
Co-authored-by: marco.massarelli <marco.massarelli@gmail.com>
Add local file loading functionality to Welcome.tsx for YAML, JSON, ZIP, and EKB files, including footprint extraction and conflict resolution.
This PR introduces a new "From Local File" option, enabling users to upload configuration files directly. For
.zipand.ekbarchives, it extractsconfig.yamland any.jsfiles from afootprints/directory, naming them based on their relative path. Existing conflict resolution logic is reused for footprints, similar to GitHub-loaded injections.Note
Adds local file upload (YAML/JSON/ZIP/EKB) with footprint extraction and conflict-aware injection processing, plus tests.
src/pages/Welcome.tsx):.yaml/.yml/.json/.zip/.ekb).processFootprintsto handleGitHubFootprint[] | LocalFootprint[]and integrate with existing conflict resolution flow.src/utils/localFiles.ts):loadLocalFileto parse config files directly or extract from archives..jsfootprints fromfootprints/in archives, preserving relative names, return{ config, footprints }.src/utils/localFiles.test.ts):config.yaml, nested footprints, and non-.jsfiltering.Written by Cursor Bugbot for commit 309aa01. This will update automatically on new commits. Configure here.