Repository navigation
Conversation
- Configured JSCAD compiler to request binary format ('stlb') in jscad.worker.ts, removing the UTF-8 string decoding steps and the regex-based ASCII header replacements.
- Updated CaseOutput['stl'], DownloadObj['content'], and Preview['content'] types in ConfigContext.tsx, Downloads.tsx, and DownloadRow.tsx to support string, ArrayBuffer, and Uint8Array.
- Refactored StlPreview.tsx to accept binary data in the stl prop, bypassing TextEncoder.encode(stlString).buffer and directly feeding the ArrayBuffer to the binary STL parser.
- Added tests in StlPreview.test.tsx for direct ArrayBuffer and Uint8Array inputs.
- Updated the download pipeline in zip.ts to output the binary file data directly when generating download files.
…ent undefined length crashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements end-to-end binary STL (stlb) parsing and resolves the KiCanvas rendering lifecycle crash: