Skip to content

Cache P-256 curve parameters per thread in p256_verify_impl #2525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khordadi merged 1 commit into from
Aug 28, 2026
Merged

Cache P-256 curve parameters per thread in p256_verify_impl #2525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions category/execution/ethereum/precompiles_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <category/core/hex.hpp>
#include <category/core/int.hpp>
#include <category/core/likely.h>
#include <category/core/thread_local.h>
#include <category/crypto/silkpre_vendor/blake2b.h>
#include <category/crypto/silkpre_vendor/ecdsa.h>
#include <category/crypto/silkpre_vendor/rmd160.h>
Expand Down Expand Up @@ -383,7 +384,8 @@ p256_verify_impl(byte_string_view const input, std::span<uint8_t, 32> const out)
Integer qx(input.data() + 96, 32);
Integer qy(input.data() + 128, 32);

DL_GroupParameters_EC<ECP> params(ASN1::secp256r1());
MONAD_THREAD_LOCAL DL_GroupParameters_EC<ECP> const params(
ASN1::secp256r1());
auto const &ec = params.GetCurve();
auto const &n = params.GetSubgroupOrder();
auto const p_mod = ec.FieldSize();
Expand All @@ -407,13 +409,14 @@ p256_verify_impl(byte_string_view const input, std::span<uint8_t, 32> const out)
return PrecompileImplResult::failure();
}

// if qy^2 ≢ qx^3 + a*qx + b (mod p): return
if (!ec.VerifyPoint({qx, qy})) {
// if (qx, qy) == (0, 0): return
// (cheaper, check first)
if (qx.IsZero() && qy.IsZero()) {
return PrecompileImplResult::failure();
}

// if (qx, qy) == (0, 0): return
if (qx.IsZero() && qy.IsZero()) {
// if qy^2 ≢ qx^3 + a*qx + b (mod p): return
if (!ec.VerifyPoint({qx, qy})) {
return PrecompileImplResult::failure();
}

Expand Down
Loading