build: emit rerun-if-changed for cmake sources in cargo build scripts - #2472
Open
eclark0426 wants to merge 1 commit into
Open
build: emit rerun-if-changed for cmake sources in cargo build scripts#2472eclark0426 wants to merge 1 commit into
eclark0426 wants to merge 1 commit into
Conversation
eclark0426
force-pushed
the
ellis/build-rerun-cmake-sources
branch
from
July 31, 2026 15:56
0c7f9da to
09d929d
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Cargo build-script change tracking for the CMake-based execution build by explicitly emitting cargo:rerun-if-changed directives for key repository CMake/source inputs.
Changes:
- Store the CMake
source_dirinMonadCMakeso it can be reused at build time. - Add
emit_source_watches(...)to printcargo:rerun-if-changedforCMakeLists.txtand core source directories. - Invoke the watch emission before running the CMake build target.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
eclark0426
force-pushed
the
ellis/build-rerun-cmake-sources
branch
from
July 31, 2026 16:20
09d929d to
68d07a7
Compare
maxkozlovsky
previously approved these changes
Aug 3, 2026
maxkozlovsky
left a comment
maxkozlovsky
left a comment
Contributor
There was a problem hiding this comment.
Approving,
non-blocking suggestion - exclude test files from the watch list, third_party alone has >50K test files which aren't needed for dependency checks
eclark0426
force-pushed
the
ellis/build-rerun-cmake-sources
branch
from
August 4, 2026 14:15
68d07a7 to
31cbb7c
Compare
eclark0426
force-pushed
the
ellis/build-rerun-cmake-sources
branch
2 times, most recently
from
August 4, 2026 18:05
87b8f9e to
5519ae8
Compare
eclark0426
force-pushed
the
ellis/build-rerun-cmake-sources
branch
from
August 4, 2026 18:05
5519ae8 to
2dbb69d
Compare
andr-dev
approved these changes
Aug 4, 2026
maxkozlovsky
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.