execution,vm: implement EIP-7708 (ETH transfers emit a log), active on Amsterdam

[brett-monad]

Emit a standardised log for every native ETH movement, so indexers can track native value the way they already track ERC-20 transfers.

Transfer(address,address,uint256) (topic0 0xddf252ad…) on every non-zero value transfer to a different account: the top-level tx transfer, value-carrying CALL, SELFDESTRUCT, and CREATE/CREATE2. This reuses the existing eth_simulate native-transfer machinery, re-gated to fire on the consensus path. Two emitter addresses are in play and 7708 does not replace one with the other: the consensus log from SYSTEM_ADDRESS fires whenever 7708 is active, and eth_simulate's synthetic from the ERC-7528 native-token address 0xeeee… is emitted alongside it when traceTransfers is set — geth returns both. Note that logIndex counts both, so a consumer dropping the 0xeeee… entries sees only even indices.

SYSTEM_ADDRESS was already a function-local constant in process_requests.cpp, the sender the EIP-7002/7251 system calls execute as. 7708 needs the same address, so it is promoted to a shared constant rather than leaving two spellings of one consensus constant that can silently diverge.

There is deliberately no Burn log

An earlier draft of EIP-7708 also specified Burn(address,uint256) for ETH destroyed by SELFDESTRUCT, and this PR used to implement it. That draft then took EIP-8246 as a prerequisite and dropped the log, because after 8246 there is no burn left to report. EIP-8246 is #2512, also based on main — it must merge first, so that by the time 7708 is live the burn never happens and the log would have no subject. geth and erigon are in the same configuration.

Earlier revisions of this description called the Burn half a monad-specific extension. That was wrong twice over — it was standard 7708 at the time, and it is not in the EIP at all now.

Active, not inert

eip_7708_active() is >= MONAD_ETH_AMSTERDAM in both trait families, and MonadTraits<MONAD_NEXT>::evm_rev() is Amsterdam, so the rule is live on the configuration that ships. Earlier revisions of this description said it was held inert with the predicate returning false, and that Amsterdam sat above LATEST_SUPPORTED_EVM_FORK so nothing in the test matrix reached it. Neither is true any more: the tests run over an explicit two-element type list — MonadRevisionConstant<MONAD_NEXT> and EvmRevisionConstant<MONAD_ETH_AMSTERDAM> — naming both revisions where 7708 is active. They are named rather than derived from LATEST_SUPPORTED_EVM_FORK so the suite does not depend on that constant having been advanced.

Spec tests

The Amsterdam spec suite is switched off on this PR, not filtered:
MONAD_NEXT_amsterdam_excluded_tests is set to BlockchainTests.*, which trips
the WILL_FAIL guard in CMakeLists.txt.

The reason is a bundle-versus-code skew, not anything wrong here. main pins
tests-monad_amsterdam@v0.2.0, which predates EIP-7708, so every fixture that
moves ETH expects no Transfer log — measured, 110 of them fail once the rule is
live. The fixtures that do expect the logs are in v0.5.0 and later, and those
bundles' genesis headers carry slotNumber and blockAccessListHash, so they
need #2439's header RLP to load at all.

This is deliberately coarse and temporary: it also drops the ~550 fixtures main
currently passes. Restoring the real list — with a bundle generated with 7708
active, plus the entries #2407 and #2512 carry on their own branches — is the
follow-up PR's job. #2439 does the same thing for the same reason.

Unit tests are unaffected and are the real gate here: test_state 379 and
test_call_trace 234 passing, both builds clean.

Ordering

No longer a stack. This PR, #2407 (EIP-8024) and #2512 (EIP-8246) are all based
on main and independent of each other and of #2439 (SLOTNUM).

One ordering constraint remains, and it is semantic rather than structural:
#2512 must merge before this PR. EIP-7708 lists requires: 8246, and without
it two SELFDESTRUCT paths still destroy ETH with no recipient — a Transfer
log cannot express that, so 7708 would claim complete native-value logging while
those burns went unlogged.

🤖 Generated with Claude Code

https://claude.ai/code/session_01T2YcdwU1mj3Lqunp9Y7pqa

[Baltoli]

Burn(address,uint256) (topic0 0xcc16f5db..), a monad-specific extension, for ETH destroyed when an EIP-6780 same-tx-created-and-destroyed account is deleted

why is there a Monad-specific extension needed?

[brett-monad]

@claude review this PR

[Copilot]

Pull request overview

Implements EIP-7708-style observability for native ETH movement by emitting synthetic ERC-20-like Transfer logs (and a Monad-specific Burn log for same-tx created+destroyed accounts) from SYSTEM_ADDRESS, wiring emission through the consensus execution path and updating tests/fixtures accordingly.

Changes:

• Add EIP-7708 feature-gate (eip_7708_active) to the traits interface and trait implementations.
• Emit consensus Transfer(from,to,value) logs for non-zero native value movement (plus optional eth_simulate synthetic logs), and emit Burn(address,uint256) logs for destroyed residual balances (inline + finalization).
• Change State::destruct_suicides to return sorted (address, balance) residuals for deterministic burn-log emission ordering; expand/adjust tests and Amsterdam fixture allowlist.

Verdict: NEEDS CHANGES
🤖 Generated with Claude Code

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/ethereum_test/exclude/MONAD_NEXT_amsterdam.cmake	Opens MONAD_NEXT+Amsterdam fixture allowlist to the full suite with updated rationale.
category/vm/evm/traits.hpp	Adds eip_7708_active() to the Traits contract and implementations.
category/rpc/monad_executor_test.cpp	Updates eth_simulate expectations to include consensus Transfer logs when 7708 is active.
category/execution/ethereum/test/test_call_trace.cpp	Updates call-trace tests and adds pinned Amsterdam fixtures for 7708 Transfer/Burn behavior.
category/execution/ethereum/state3/state.hpp	Updates destruct_suicides API to return burned residual balances for 7708.
category/execution/ethereum/state3/state.cpp	Captures and sorts burned residual balances during suicide destruction for deterministic Burn emission.
category/execution/ethereum/state2/test/test_state.cpp	Adds pinned Amsterdam test asserting burned residuals are returned sorted by address.
category/execution/ethereum/process_requests.cpp	Removes local SYSTEM_ADDRESS spelling in favor of shared constant.
category/execution/ethereum/execute_transaction.cpp	Emits finalization Burn logs based on destruct_suicides return value when 7708 is active.
category/execution/ethereum/execute_transaction_test.cpp	Adds pinned Amsterdam test validating finalization-site Burn log behavior.
category/execution/ethereum/evmc_host.hpp	Promotes SYSTEM_ADDRESS and SIMULATE_NATIVE_TOKEN_LOG_ADDRESS, adds Burn-log builder, and emits 7708 Transfer/Burn logs.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

This PR adds EIP-7708 Transfer log emission from SYSTEM_ADDRESS on every value-carrying transfer (top-level tx, value-carrying CALL, SELFDESTRUCT, CREATE/CREATE2), plus a monad-specific Burn log at the two sites where an EIP-6780 same-tx-created-and-destroyed account loses ETH: inline at selfdestruct-to-self, and at finalization for residual balance. The value > 0 && from != to predicate is shared with the existing eth_simulate traceTransfers machinery; both consensus and ERC-7528 synthetic emissions coexist rather than one replacing the other, matching geth. SYSTEM_ADDRESS is promoted from a function-local constant in process_requests.cpp to a shared inline constexpr in evmc_host.hpp. Active on MonadTraits<MONAD_NEXT> (which maps to MONAD_ETH_AMSTERDAM) and on EvmTraits<MONAD_ETH_AMSTERDAM> and later.

I traced the following and found nothing wrong:

• Refactored emit_native_transfer_event: for every combination of eip_7708_active and log_native_transfers_ the pre-activation truth table matches the old single-branch check; post-activation the consensus log is emitted unconditionally on the shared predicate and the synthetic still fires only under the flag.
• EvmcHost::selfdestruct inline burn: is_current_incarnation(address) is captured before state_.selfdestruct (correct — the selfdestruct doesn't touch incarnation, but this reads consistently even if it did). The burn is gated on created_this_tx && beneficiary == address && transferred_balance > 0, and the paired emit_native_transfer_event self-skips on from == to, so no double emission. The comment "store_log without a matching on_log" documents the intentional trace/receipt asymmetry.
• Finalization path: destruct_suicides runs after the beneficiary award, captures (address, balance) inside the CANCUN+ branch (guarded by static_assert(!eip_7708_active() || evm_rev() >= CANCUN) — nice), and sorts by address. execute_final then emits Burn logs from the returned pairs. Ordering matters and is called out in the comment.
• Revert safety: state_.store_log is versioned, so the inline burn rolls back with logs_.pop_reject if the emitting frame reverts. Finalization burns are at version 0 and don't need revert semantics.
• [[maybe_unused]] auto const burned = state.destruct_suicides<traits>(); — burned is only touched inside if constexpr (eip_7708_active()), so the attribute is necessary to silence the unused-variable warning on the discarded-branch path; NRVO keeps the returned empty vector free of overhead pre-activation.
• Trait wiring: the eip_7708_active() requirement is added to the Traits concept, and both EvmTraits and MonadTraits add matching consteval predicates keyed on MONAD_ETH_AMSTERDAM.

Test coverage is thorough — top-level Transfer log, consensus + synthetic pairing, inline burn, finalization burn (via beneficiary award landing on a selfdestructed account), address ordering of the burned set, and the burn-out-of-call-trace invariant. All are pinned to EvmTraits<MONAD_ETH_AMSTERDAM> since no monad revision reaches AMSTERDAM in the shared matrix yet, with the !eip_7708_active() static_asserts on the two touched pre-activation tests making the intent explicit.

One meta note that doesn't block: the PR title still says "held inert on MONAD_NEXT", but the code and the commit message activate on MONAD_NEXT (via MonadTraits<MONAD_NEXT>::evm_rev() == MONAD_ETH_AMSTERDAM), and the MONAD_NEXT_amsterdam.cmake allowlist opens to "*" — consistent with activation, not inertness. Worth updating the title before merge.

All CI green (clang-format, clang-tidy, trait instantiation, Debug+ASAN, RelWithDebInfo, RISC-V, VM tests, CodeQL).

Verdict: CORRECT

🤖 Generated with Claude Code

[brett-monad]

Note for the rebase onto the EIP-8246 branch, which sits below this one: the Burn log becomes unreachable the moment 8246 lands.

eip_7708_active() and eip_8246_active() are the same predicate for both trait families — both are >= MONAD_ETH_AMSTERDAM. So with 8246 underneath:

• destruct_suicides' if constexpr (eip_7708_active()) capture into burned can only fire when 8246 is off, which is never when 7708 is on.
• The inline selfdestruct-to-self Burn emit in evmc_host.hpp is likewise unreachable, along with make_eip7708_burn_log and the Burn(address,uint256) topic.

Since 8246 lands below rather than above, the clean outcome is that the rebased version of this PR never introduces the Burn log at all, rather than adding it and deleting it a commit later. That also means the std::ignore call sites in test_state.cpp and the Eip7708StateTest / Eip7708FinalizationTest burn cases never get written.

Two things to fix while rebasing: make_eip7708_burn_log's comment currently says EIP-8246 "would remove both burns; monad has declined it", which the 8246 branch contradicts; and the exclusions for the fixtures 8246 invalidates belong in this PR's MONAD_NEXT_amsterdam.cmake rather than the 8246 PR's, because this is the PR that removes the allowlist. Test names there are fs::relative paths, so they begin for_monad_next/ — the osaka.cmake form omits that level and matches nothing.

Consistent with geth, whose Amsterdam path emits only the transfer log, and only when the beneficiary differs from the destructing account.

[brett-monad]

Done — recording it here so nobody actions the comment above twice.

EIP-8246 now sits directly beneath this PR as #2512, and this PR no longer introduces the Burn log at all rather than adding it and deleting it a commit later. make_eip7708_burn_log, both emit sites, the destruct_suicides vector return (back to void), the 23 std::ignore call sites and the three burn test suites are all gone; there are no cc16f5db references left in the tree.

The stale comment claiming monad had declined 8246 went with it, as did the PR title and description, which said the same thing.

On the fixtures: the exclusions landed here rather than in #2512, for the reason given above — this is the PR that removes the allowlist, so this is where they become live. Measured rather than predicted: 601 of 617 pass, and the 15 that fail are exactly the set carrying the pre-8246 SELFDESTRUCT expectations. Both burn_logs fixtures that assert the absence of a burn pass and are deliberately not excluded. Names use the for_monad_next/ prefix, since they are fs::relative paths — the osaka.cmake form omits that level and would have matched nothing.