Propagate exceptions in outcome

[andreaslyn]

No description provided.

[Copilot]

Pull request overview

This PR updates transaction execution to propagate exceptions reliably across the fiber-based “previous transaction” dependency chain, by (a) using future.get() where rethrow is desired and (b) introducing an Outcome<T> container to carry either a normal Result<T> error or an exception.

Changes:

• execute_transaction: switch from future.wait() to future.get() so exceptions from the previous transaction are rethrown.
• execute_block: store per-transaction results as Outcome<Receipt> so exceptions are propagated via outcomes rather than via the final promise get().
• core/result: add Outcome<T> and helpers to convert between Result<T> and Outcome<T> / rethrow exceptions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File	Description
category/execution/monad/reserve_balance/reserve_balance_contract_test.cpp	Renames test-local Outcome enum to avoid clashing with the new monad::Outcome type alias.
category/execution/ethereum/execute_transaction.cpp	Uses future.get() to rethrow exceptions from the previous transaction when stalling / early-exiting on validation error.
category/execution/ethereum/execute_block.cpp	Tracks each transaction’s completion as an Outcome<Receipt> and defers exception propagation to the aggregation loop.
category/core/result.hpp	Introduces Outcome<T> plus conversion helpers; current implementation needs fixes for exception rethrow type and move semantics.

Comments suppressed due to low confidence (1)

category/core/result.hpp:54

• result_from_outcome_or_throw currently calls boost::rethrow_exception(out.exception()), but out.exception() is std::exception_ptr with the default Outcome alias. This should use std::rethrow_exception. Also, return the value by moving out of out to avoid unintended copies / move-only failures.

template <typename T>
Result<T> result_from_outcome_or_throw(Outcome<T> out)
{
    if (out.has_exception()) {
        boost::rethrow_exception(out.exception());
    }
    if (out.has_error()) {
        return std::move(out).assume_error();
    }
    return out.assume_value();
}

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.