Fix Dynamo cluster watcher shutdown ordering - #3932
Merged
Merged
Conversation
Keep the watcher running until its task queue and DynamoDB service have stopped accepting work. This lets shutdown remove the local member while DynamoDB is still available.
ThePumpingLemma
marked this pull request as ready for review
September 22, 2026 15:44
tgregory-block
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
During shutdown,
DynamoClusterWatcherTaskremoves the local member from DynamoDB. Its service graph did not require the repeated-task queue or DynamoDB service to remain available, so either dependency could stop before cleanup ran.This adds both dependencies to the watcher service. It also logs watcher startup and shutdown to make lifecycle ordering visible.
Testing Strategy
No manual testing. CI covers this lifecycle change.
Risk
Low. This changes only service startup and shutdown order in
misk-clustering-dynamodb.Generated with Codex