Scope startup checks to requested career work - #4149
Draft
woud420 wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Welcome to career-ops, @woud420! Thanks for your first PR. A few things to know:
We review every PR by hand. Join our Discord if anything blocks you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Primary changes
Repository maintenance and explanation requests currently inherit a silent updater check and onboarding before any other work. Scope updater checks to update-related requests and run setup checks only when the requested product mode needs prerequisites that are not already known to be ready.
Reviewer walkthrough
Correctness and invariants
The Data Contract, privacy boundaries, updater apply confirmation, and candidate-source requirements remain in place. The doctor check's template-copy side effect is explicit. Unrelated missing files no longer block otherwise valid work.
Testing and QA
node --test tests/agent-docs-script-refs.test.mjs: 7 passed.test-all.mjsrouting and interview-prep contract blocks in a filesystem-only harness: 9 assertions passed; full suite not run.git diff --check: passed; onlyAGENTS.mdchanged.Risk / Rollout
This narrows setup and permission-sensitive startup behavior and remains a draft for review. A future runtime check cannot be assumed cached across sessions; the rule is limited to known readiness in the current session and rechecks when setup changes. Existing apply/submit approvals remain unchanged.
Resolves ENG-447