docs(cv-visual): fix the baselines.json path (test/ -> tests/) - #4147
docs(cv-visual): fix the baselines.json path (test/ -> tests/)#4147Zoubeir23 wants to merge 1 commit into
Conversation
career-ops#4129: the harness lives at tests/cv-visual/ (playwright.cv.config.mjs sets testDir: './tests/cv-visual'), and test/ no longer exists upstream. The doc still pointed reviewers at the stale path. node test-all.mjs: 8725 passed, 0 failed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe visual testing documentation now points to ChangesVisual testing documentation
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to This documentation-only change directs maintainers to the correct existing baseline file, with no identified merge risk. 🚥 Pre-merge checks | ✅ 9✅ Passed checks (9 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
🚀 Post-Merge Actions
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #4129.
docs/CV_VISUAL_TESTING.mdpointed attest/cv-visual/baselines.json. Theharness lives at
tests/cv-visual/—playwright.cv.config.mjssetstestDir: './tests/cv-visual', andtest/no longer exists upstream.node test-all.mjs: 8725 passed, 0 failed.Updated
docs/CV_VISUAL_TESTING.md:32to referencetests/cv-visual/baselines.json.This matches
playwright.cv.config.mjs:4, which usestests/cv-visualas the test directory. Users can now update the correct baseline file.System files touched: none of
AGENTS.md,modes/,update-system.mjs,DATA_CONTRACT.md,providers/, or.github/.