Skip to content

docs(cv-visual): fix the baselines.json path (test/ -> tests/) - #4147

Open
Zoubeir23 wants to merge 1 commit into
career-ops-hq:mainfrom
Zoubeir23:Fix/4129-cv-visual-testing-docs-path
Open

docs(cv-visual): fix the baselines.json path (test/ -> tests/)#4147
Zoubeir23 wants to merge 1 commit into
career-ops-hq:mainfrom
Zoubeir23:Fix/4129-cv-visual-testing-docs-path

Conversation

@Zoubeir23

@Zoubeir23 Zoubeir23 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Fixes #4129.

docs/CV_VISUAL_TESTING.md pointed at test/cv-visual/baselines.json. The
harness lives at tests/cv-visual/playwright.cv.config.mjs sets
testDir: './tests/cv-visual', and test/ no longer exists upstream.

node test-all.mjs: 8725 passed, 0 failed.

Updated docs/CV_VISUAL_TESTING.md:32 to reference tests/cv-visual/baselines.json.

This matches playwright.cv.config.mjs:4, which uses tests/cv-visual as the test directory. Users can now update the correct baseline file.

System files touched: none of AGENTS.md, modes/, update-system.mjs, DATA_CONTRACT.md, providers/, or .github/.

career-ops#4129: the harness lives at tests/cv-visual/ (playwright.cv.config.mjs
sets testDir: './tests/cv-visual'), and test/ no longer exists upstream. The
doc still pointed reviewers at the stale path.

node test-all.mjs: 8725 passed, 0 failed.
Copilot AI lite review requested due to automatic review settings September 13, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2e40fda1-47fc-49db-9bdc-98707d2e0ffa

📥 Commits

Reviewing files that changed from the base of the PR and between bb641dc and 04ca5fb.

📒 Files selected for processing (1)
  • docs/CV_VISUAL_TESTING.md
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • career-ops-hq/career-ops-docs (manual)

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The visual testing documentation now points to tests/cv-visual/baselines.json instead of the obsolete test/cv-visual/baselines.json.

Changes

Visual testing documentation

Layer / File(s) Summary
Correct baseline path
docs/CV_VISUAL_TESTING.md
The intentional baseline update instruction now references tests/cv-visual/baselines.json at line 32.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 04ca5

This documentation-only change directs maintainers to the correct existing baseline file, with no identified merge risk.

🚥 Pre-merge checks | ✅ 9
✅ Passed checks (9 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title uses the valid docs(cv-visual): Conventional Commits prefix and accurately describes the path correction in docs/CV_VISUAL_TESTING.md.
Linked Issues check ✅ Passed Issue #4129 requires the documentation to use tests/cv-visual/baselines.json and to match the harness directory. docs/CV_VISUAL_TESTING.md:31 uses the corrected path. playwright.cv.config.mjs:4
Out of Scope Changes check ✅ Passed The pull request changes only the baseline path in docs/CV_VISUAL_TESTING.md:31. This change directly supports issue #4129. No unrelated source, configuration, or test changes are present in the sup…
User Layer Untouched ✅ Passed PASS: The PR changes only docs/CV_VISUAL_TESTING.md. The changed line is docs/CV_VISUAL_TESTING.md:32. The path is in the documented system layer, not the listed user layer. No user-layer file was…
No Personal Data ✅ Passed PASS: The diff changes only the documentation path at docs/CV_VISUAL_TESTING.md:32. It adds no person's name, contact details, email, phone number, or real CV. The CV term refers to visual-testing…
Shipped File Registered ✅ Passed PASS: The PR modifies only docs/CV_VISUAL_TESTING.md:32; it does not add a new top-level .mjs, .md, template, or config file. SYSTEM_PATHS in update-system.mjs:128 therefore requires no upda…
Provider Contract ✅ Passed PASS: The PR changes only docs/CV_VISUAL_TESTING.md:32, correcting test/cv-visual/baselines.json to tests/cv-visual/baselines.json. The authoritative diff contains no changes under providers/,…
Agent-Operated Pr Disclosure ✅ Passed No agent disclosure warning applies: the reviewed head commit is authored by zoubeir23, not app/copilot-swe-agent, and the available review refs expose no copilot/* branch. The PR only changes t…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ register-shipped-file
  • 🛠️ provider-test-scaffold
  • 🛠️ sync-language-mode
🚀 Post-Merge Actions
  • localization drift report
  • documentation drift report

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs/CV_VISUAL_TESTING.md points at test/cv-visual/ instead of tests/cv-visual/

2 participants