fix(node): stop the recommended Node version travelling as the required one - #74
Open
santifer wants to merge 1 commit into
Open
fix(node): stop the recommended Node version travelling as the required one#74santifer wants to merge 1 commit into
santifer wants to merge 1 commit into
Conversation
…ed one Four short-form surfaces said "if you have Node 22.5+", which reads as the floor. It is not. The core declares engines >=18, docs/SETUP.md says 18+, and our own /docs pages already say it correctly in all three languages: minimum 18, works with a warning, 22.5+ recommended because it enables the SQLite tracker index, and Node 20 or newer only for the Gemini CLI path. So the long form was right and the short forms dropped the qualifier, which turned a recommendation into a barrier. Someone on Node 18 reads three comparison pages and a blog guide telling them they need 22.5, and stops at the step where people already abandon most. The core has a module for exactly this failure, lib/gemini-node-floor.mjs, and its header names this site as the case that motivated it: the fact lived only in prose, prose copies drifted, and the Spanish and French pages had asserted Node 20 as a general requirement. That part is already fixed here; this is the same class of drift in the surfaces short enough to lose the context. 18+ rather than a fuller sentence because these strings are one line in a comparison cell. The place to explain the recommendation is /docs, which does. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BcPLgMFMs2B4SJv3vfq8jv
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 54 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
RiCSaucd
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the second blog refresh, and it turned out not to need the maintainer after all.
I had this wrong, and so did search-ops
I reported five conflicting Node numbers in the core and routed it to the maintainer as undecidable. Two of my five rows were wrong (I attributed a
grephit across two files to both of them), and the remaining picture is not a conflict at all:package.jsonengines>=18docs/SETUP.mdline 618+, "the Gemini CLI integration requires Node.js 20+"lib/gemini-node-floor.mjsGEMINI_MIN_MAJOR = 20/docs, all three locales22.5is a recommendation, not a requirement, and our long-form docs state it properly.The actual bug
Four short-form surfaces dropped the qualifier:
comparisons.json×3 — "10-15 minutes if you have Node 22.5+"/blog/the-complete-ai-job-search-guide— "Setup takes fifteen minutes if you have Node 22.5+"Read alone, each says you need 22.5. Someone on Node 18 reads three comparison pages and a guide telling them they are under-equipped, and stops at the step where people already abandon most. Same principle as the
applystring: a sentence that travels alone has to be correct alone.The core already wrote the lesson down
lib/gemini-node-floor.mjsexists because of this exact failure, and its header names this site:That ES/FR drift is already fixed here. This is the same class of drift in the surfaces short enough to lose the context.
Why
18+and not a longer sentenceThese are single-line comparison cells. The floor is the only part that belongs in one line; the place to explain the recommendation is
/docs, which does, in three languages.Also
lastModifiedon the guide moves to today. That is the second of the three overdue refreshes; its central stale fact was this line.Verification
JSON parses, production build clean. Every surviving
22.5sits next to an explicitminimum 18.🤖 Generated with Claude Code
https://claude.ai/code/session_01BcPLgMFMs2B4SJv3vfq8jv