Skip to content

pdf mode reference omits --kind=cv|cover and the pdf-index kind column (en/fr/es) #72

Description

@rubicon

The PDF-mode reference pages do not mention --kind, and do not describe how the PDF manifest distinguishes a CV row from a cover-letter row.

Verified against HEAD on all three localisations:

page --kind pdf-index
content/docs/reference/modes/pdf.mdx 0 0
content/docs/reference/modes/pdf.fr.mdx 0 0
content/docs/reference/modes/pdf.es.mdx 0 0

Why it matters now

generate-pdf.mjs writes data/pdf-index.tsv with a kind column, and --kind=cv|cover selects which row an artifact is filed as. Without it, a cover letter can land in the row a tailored CV should own, and the resolver that reads the manifest then hands back the wrong document.

That is not hypothetical. career-ops-hq/career-ops#3959 fixes a path where an unrecognised kind was silently recorded as cv and evicted the report's real CV row. A reader of the current pdf-mode page has no way to know the flag exists, so the failure looks like the tool losing their CV.

Suggested content

Enough to make the flag discoverable and the column legible:

  • --kind=cv|cover in the flags section, with the default described (the kind is inferred from the output filename when the flag is absent).
  • One line on data/pdf-index.tsv carrying a kind column, and that a report can have both a cv row and a cover row.
  • A note that the manifest is written by generate-pdf.mjs and should not be hand-edited, which the file's own header comment already says.

Happy to open the PR for the English page and mirror it to fr and es if that is the preferred flow here. Flagging rather than assuming, since I do not know whether translations are expected to land in the same PR or follow separately in this repo.

Origin

Raised as a review thread on career-ops-hq/career-ops#3959, where it cannot be fixed because it needs a change in this repo.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions