fix(skills): read skill markdown as UTF-8 - #4995
Open
JieZeng777 wants to merge 1 commit into
Open
Conversation
JieZeng777
force-pushed
the
codex/fix-skill-validator-utf8
branch
from
August 24, 2026 07:04
19c731d to
6e9e48f
Compare
Collaborator
|
@JieZeng777 thanks for your contribution. Please click the CLA assitant button to sign the CLA first. |
Author
|
@WillemJiang Thanks! I’ve signed the CLA, and the I also investigated the failing Skill Review CI. The four reported errors come from existing files in the |
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Windows systems whose default locale is not UTF-8, the skill creator validator reads
SKILL.mdwith the platform default encoding. Localized UTF-8 skills can therefore fail validation withUnicodeDecodeError, even though the skill file itself is valid.What changed
SKILL.mdexplicitly as UTF-8 in the skill creator validator.Surface area
frontend/backend/applanggraph.json, or prompt changedocker/or sandboxed executionskills/backend/pyproject.tomlorfrontend/package.jsonScreenshots / Recording
Not applicable; this change has no UI surface.
Bug fix verification
tests/skills/test_skill_creator_quick_validate.pymainand green on this branch? Yes. Before the fix, the regression test raised the simulated GBKUnicodeDecodeError; after the fix, it passes.Validation
python -m pytest tests/skills -q— 52 passedpython -m ruff check --config backend/ruff.toml tests/skills/test_skill_creator_quick_validate.py— passedpython -m ruff format --check --config backend/ruff.toml tests/skills/test_skill_creator_quick_validate.py— passedpython skills/public/skill-creator/scripts/quick_validate.py skills/public/skill-creator— Skill is validAI assistance
Tool(s) used: Codex
How you used it: Codex helped inspect the Windows locale failure, write the regression test, implement the minimal encoding fix, update documentation, and run validation. I reviewed and understand the resulting change.