fix(tui): scroll transcript with PageUp/PageDown while composer is focused - #4991
Open
PiedPiper911 wants to merge 4 commits into
Open
fix(tui): scroll transcript with PageUp/PageDown while composer is focused#4991PiedPiper911 wants to merge 4 commits into
PiedPiper911 wants to merge 4 commits into
Conversation
|
Wu Renliang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PageUp/PageDown now scroll the transcript while the composer stays focused (the composer keeps focus), and transcript refreshes preserve the user's scroll position when they have scrolled away from the bottom — follow resumes only once they return to the bottom. Fixes #4974.
Surface area
Screenshots / Recording
N/A — terminal UI change; no visual diff to attach from this environment.
Bug fix verification
backend/tests/test_tui_app.py::test_pageup_pagedown_scroll_transcript_while_composer_focusedand::test_refresh_transcript_preserves_scroll_position_when_scrolled_up— the first presses PageUp/PageDown while the composer is focused and asserts the transcript scrolls; the second asserts a streamed refresh does not snap the user back to the bottom.mainand green on this branch? The new tests encode the previously-broken behavior (before the fix, PageUp/PageDown were not routed to#scrolland_refresh_transcriptalways calledscroll_end); they pass on this branch. I did not run them againstmainin this environment.pytest tests/test_tui_app.py— 20 passed.Validation
Backend:
pytest tests/test_tui_app.py(20 passed) +py_compileon the changed files. Not run here:make lint/ the full backend suite (sandbox limits).AI assistance
Tool(s) used: WorkBuddy (AI coding assistant)
How you used it: AI implemented the fix and the two tests from the issue's reproduction notes; I reviewed every line of the diff and ran the test suite.