Skip to content

fix(skills): refresh user storage after config reload - #4972

Merged
WillemJiang merged 2 commits into
bytedance:mainfrom
wutongyuonce:fix/skills-user-storage-config-reload
Aug 25, 2026
Merged

fix(skills): refresh user storage after config reload#4972
WillemJiang merged 2 commits into
bytedance:mainfrom
wutongyuonce:fix/skills-user-storage-config-reload

Conversation

@wutongyuonce

@wutongyuonce wutongyuonce commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Why

When the app config is hot-reloaded, the per-user skill storage could remain bound to paths from the previous config instance.

What changed

  • Rebuild per-user skill storage when the app config instance changes.
  • Keep reusing storage when the config instance is unchanged.
  • Add a regression test covering both behaviors.

Validation

  • git diff --check
  • Added backend/tests/test_skill_storage_lifecycle.py::test_user_storage_is_rebuilt_when_app_config_changes

Fixes #4971

@wutongyuonce
wutongyuonce marked this pull request as ready for review August 24, 2026 06:21
@github-actions github-actions Bot added area:skills Skills under skills/ or the skills harness risk:medium Medium risk: regular code changes size/S PR changes 20-100 lines labels Aug 24, 2026
@WillemJiang WillemJiang added this to the 2.1.0 milestone Aug 25, 2026
@WillemJiang
WillemJiang merged commit 013dca6 into bytedance:main Aug 25, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:skills Skills under skills/ or the skills harness risk:medium Medium risk: regular code changes size/S PR changes 20-100 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(skills): user storage cache ignores hot-reloaded config

2 participants