Skip to content

fix: operator permission check always triggering + typos - #1922

Open
fix2015 wants to merge 1 commit into
bytedance:mainfrom
fix2015:fix/operator-check-and-typos
Open

fix: operator permission check always triggering + typos#1922
fix2015 wants to merge 1 commit into
bytedance:mainfrom
fix2015:fix/operator-check-and-typos

Conversation

@fix2015

@fix2015 fix2015 commented Jul 1, 2026

Copy link
Copy Markdown

Found a logic bug in the operator permission check — the condition was:

```js
if (operator === Operator.LocalBrowser || Operator.LocalComputer)
```

This always evaluates to true because `Operator.LocalComputer` is a non-empty string on its own. So the permission dialog was firing for every operator type, not just local ones. Added the missing `operator ===` comparison.

Also fixed a few other things while I was in there:

  • `Object.keys(settings)` check in Settings was always truthy since arrays are truthy — added `.length > 0`
  • "Vision-Lanuage Model" → "Vision-Language Model" in both package.json files
  • "lenght" → "length" in a browser debug log
  • "Get Start" → "Get Started" in the settings UI button

the permission check was (operator === Operator.LocalBrowser || Operator.LocalComputer)
which always evaluates to true because the second part is just a non-empty
string. added the missing operator === comparison.

also:
- Object.keys(settings) check always truthy — added .length > 0
- "Vision-Lanuage Model" → "Vision-Language Model" in package descriptions
- "lenght" → "length" in browser log
- "Get Start" → "Get Started" in settings button
@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for agent-tars-docs canceled.

Name Link
🔨 Latest commit 25d75ea
🔍 Latest deploy log https://app.netlify.com/projects/agent-tars-docs/deploys/6a454ce9ce07120009a423ae

@netlify

netlify Bot commented Jul 1, 2026

Copy link
Copy Markdown

Deploy Preview for tarko canceled.

Name Link
🔨 Latest commit 25d75ea
🔍 Latest deploy log https://app.netlify.com/projects/tarko/deploys/6a454ce9f0a470000827c0e4

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants