Draw a uniform filled shape on a single tap

[stephanepechard]

Problem

A single tap on the drawing view (a touch that ends without dragging) produced nothing for most shapes: endShape() detected the empty/half-formed shape via hasBeenTapped() and removed it, with the handleTap(...) call left commented out.

Change

• Detect a tap at the view level: a touch whose movement never exceeds TAP_TOLERANCE is treated as a tap rather than a drag (more reliable than the per-shape hasBeenTapped() bounds check, which never fired for BrushShape).
• On a tap, draw a uniform filled version of the selected shape, sized from the current shape thickness: a circle for an oval, a square for a rectangle.
• Shapes with no meaningful single-point form (line, arrow, freehand brush) and taps while erasing draw nothing.
• OvalShape.drawCircle(...) / RectangleShape.drawSquare(...) build the centered shape path.

Tests

Adds instrumented tests in DrawingViewTouchEventTest:

• testTapWithOvalDrawsUniformFilledCircle
• testTapWithRectangleDrawsUniformFilledSquare
• testTapWithPointlessShapeDrawsNothing (line/brush/arrow)
• testTapWhileErasingDrawsNothing

[Copilot]

Pull request overview

This PR makes single taps on DrawingView produce a visible result for supported shapes by detecting taps at the view level (movement within a small tolerance) and, on tap, drawing a uniform filled circle/square sized from the current shape thickness. It also adds instrumented tests covering the new tap behavior.

Changes:

• Add view-level tap detection (tap vs drag) and route taps to a new handleTap(...) implementation.
• On tap, draw a filled uniform circle (Oval) or square (Rectangle); do nothing for line/arrow/brush and while erasing.
• Add instrumented tests for tap behavior for oval/rectangle, pointless shapes, and erasing.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
photoeditor/src/main/java/ja/burhanrashid52/photoeditor/shape/RectangleShape.kt	Adds drawSquare(...) helper for tap-created square paths.
photoeditor/src/main/java/ja/burhanrashid52/photoeditor/shape/OvalShape.kt	Adds drawCircle(...) helper for tap-created circle paths.
photoeditor/src/main/java/ja/burhanrashid52/photoeditor/DrawingView.kt	Implements tap detection and tap-to-filled-shape behavior.
photoeditor/src/androidTest/java/ja/burhanrashid52/photoeditor/DrawingViewTouchEventTest.kt	Adds new instrumented tests validating tap outcomes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[burhanrashid52]

@stephanepechard Have a look at this PR agent review. And feel free to close the conversation if its not relevant. Please merge it and release it once that is done.

[stephanepechard]

@burhanrashid52 I cannot merge, I need an approving review. AI comments have been resolved.